Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate consumesMany() to edm::GetterOfProducts() in GlobalRecHitsAnalyzer #40923

Merged
merged 4 commits into from Mar 20, 2023

Conversation

jeongeun
Copy link
Contributor

@jeongeun jeongeun commented Mar 2, 2023

PR description:

Based on PR #40167 .
Migrate GlobalRecHitsAnalyzer away from consumesMany() to use edm::GetterOfProducts().

    modified:   Validation/GlobalRecHits/interface/GlobalRecHitsAnalyzer.h
    modified:   Validation/GlobalRecHits/src/GlobalRecHitsAnalyzer.cc

PR validation:

Tested in CMSSW_13_0_0_pre4, the basic test passed in the CMSSW PR instructions

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2023

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40923/34406

  • This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40923/34407

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2023

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

  • Validation/GlobalRecHits (dqm)

@emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks.
@missirol this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-133d9c/31032/summary.html
COMMIT: c915938
CMSSW: CMSSW_13_1_X_2023-03-02-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40923/31032/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 9 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3529699
  • DQMHistoTests: Total failures: 70
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3529607
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

The PR introduces changes in DQM plots in GlobalRecHitsV/HCals which are not expected in a technical PR like this one.
See e.g.:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/baseLineComparisons/CMSSW_13_1_X_2023-03-02-2300+133d9c/55822/10024.0_TTbar_13+2017/GlobalRecHitsV_HCals.html

@makortel makortel mentioned this pull request Mar 9, 2023
9 tasks
@makortel
Copy link
Contributor

I took a look and the difference is caused by EDAliases (from SwitchProducer). It seems that consumesMany() uses only the "real" products, whereas GetterOfProducts includes also the alias products. @Dr15Jones, maybe we should explicitly ignore alias branches (or do it by default) in GetterOfProducts?

@Dr15Jones
Copy link
Contributor

@makortel GetterOfProducts doesn't actually do the filtering itself, it takes as an argument a functor that does the filtering. In all the cases using GetterOfProducts the filter being used is ProcessMatch which only checks the BranchDescription for matching process names. To filter out 'duplicate' alias calls, we'd need to define a new filter and use that as the matcher.

@makortel
Copy link
Contributor

Thinking a bit further, I'd say we can't generally decide between the alias product and the original (aliased-for) product (or if the code really wants to consume both), and that decision should be left for the user.

@emanueleusai
Copy link
Member

@jeongeun I believe @makortel 's suggestion solves the problem we are seeing in the DQM comparison. Could you please implement it so we can retest and approve the PR?

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40923/34617

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

Pull request #40923 was updated. @emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please check and sign again.

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-133d9c/31260/summary.html
COMMIT: 0783b65
CMSSW: CMSSW_13_1_X_2023-03-13-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40923/31260/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 11834.011834.0_TTbar_14TeV+2021PU/step2_TTbar_14TeV+2021PU.log

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 7 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3550756
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3550730
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-133d9c/31347/summary.html
COMMIT: 0783b65
CMSSW: CMSSW_13_1_X_2023-03-16-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40923/31347/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 14 lines to the logs
  • Reco comparison results: 16 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3550819
  • DQMHistoTests: Total failures: 8
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3550789
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@emanueleusai
Copy link
Member

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit d4d20ac into cms-sw:master Mar 20, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants