New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate consumesMany() to edm::GetterOfProducts() in GlobalRecHitsAnalyzer #40923
Conversation
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40923/34406
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40923/34407
|
A new Pull Request was created by @jeongeun (JeongEun Lee) for master. It involves the following packages:
@emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-133d9c/31032/summary.html Comparison SummarySummary:
|
The PR introduces changes in DQM plots in GlobalRecHitsV/HCals which are not expected in a technical PR like this one. |
I took a look and the difference is caused by EDAliases (from SwitchProducer). It seems that |
@makortel |
Thinking a bit further, I'd say we can't generally decide between the alias product and the original (aliased-for) product (or if the code really wants to consume both), and that decision should be left for the user. |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40923/34617
|
Pull request #40923 was updated. @emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please check and sign again. |
please test |
-1 Failed Tests: RelVals-INPUT RelVals-INPUT
Comparison SummarySummary:
|
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-133d9c/31347/summary.html Comparison SummarySummary:
|
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Based on PR #40167 .
Migrate GlobalRecHitsAnalyzer away from consumesMany() to use edm::GetterOfProducts().
PR validation:
Tested in CMSSW_13_0_0_pre4, the basic test passed in the CMSSW PR instructions