Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added skimming filter for disappearing muons [13_0_X Backport] #40937

Merged
merged 8 commits into from Mar 20, 2023

Conversation

revering
Copy link

@revering revering commented Mar 2, 2023

PR description:

Backport of #40666 to 13_0_X for 2023 data taking.

Michael Revering added 6 commits February 1, 2023 12:32
Applied code-checks

Added code-checks and code-format
Added check of eta and phi when matching the track to a vertex.
match standards. Added skim configuration into Skims_PDWG_cff.py
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 2, 2023

A new Pull Request was created by @revering for CMSSW_13_0_X.

It involves the following packages:

  • Configuration/Skimming (pdmv)

@cmsbuild, @bbilin, @sunilUIET, @kskovpen can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos, @youyingli this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@youyingli
Copy link
Contributor

@kskovpen , this is the backport of #40666 . Please mark "backport" and test.

@perrotta
Copy link
Contributor

perrotta commented Mar 4, 2023

backport of #40666

@perrotta
Copy link
Contributor

perrotta commented Mar 4, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f0ab9c/31066/summary.html
COMMIT: b5c98a2
CMSSW: CMSSW_13_0_X_2023-03-03-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40937/31066/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3557934
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3557908
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@kskovpen
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio rappoccio changed the title Disappearing muons skim 13_0_X Backport Added skimming filter for disappearing muons [13_0_X Backport] Mar 10, 2023
fillDescriptions, and made config parameters const
@cmsbuild
Copy link
Contributor

Pull request #40937 was updated. @cmsbuild, @bbilin, @sunilUIET, @kskovpen can you please check and sign again.

configuration from fillDescriptions and load them into cff file
@cmsbuild
Copy link
Contributor

Pull request #40937 was updated. @cmsbuild, @bbilin, @sunilUIET, @kskovpen can you please check and sign again.

@youyingli
Copy link
Contributor

Hi @perrotta , could you also test it?

@perrotta
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f0ab9c/31296/summary.html
COMMIT: 8ee8512
CMSSW: CMSSW_13_0_X_2023-03-15-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40937/31296/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3551048
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3551026
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@kskovpen
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit cb88613 into cms-sw:CMSSW_13_0_X Mar 20, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants