Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

13_1: 2023 FastSim Workflow #40954

Merged
merged 1 commit into from Mar 4, 2023
Merged

13_1: 2023 FastSim Workflow #40954

merged 1 commit into from Mar 4, 2023

Conversation

srimanob
Copy link
Contributor

@srimanob srimanob commented Mar 3, 2023

PR description:

This PR is to add 2023 FS workflows.

PR validation:

The new workflow, 14034.0_TTbar_14TeV+2023FS, runs fine.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR should be backported to 13_0, to allow to produce 2023 FastSim workflows for validation and production.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40954/34438

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2023

A new Pull Request was created by @srimanob (Phat Srimanobhas) for master.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@srimanob
Copy link
Contributor Author

srimanob commented Mar 3, 2023

test parameters:

  • workflows = 14034.0
  • relvals_opt = --what cleanedupgrade,standard,highstats,pileup,generator,extendedgen,production,ged,machine,premix,nano,gpu

@srimanob
Copy link
Contributor Author

srimanob commented Mar 3, 2023

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 3, 2023

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5af89d/31051/summary.html
COMMIT: 5c97335
CMSSW: CMSSW_13_1_X_2023-03-03-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40954/31051/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

ValueError: Undefined workflows: 14034.0

@srimanob
Copy link
Contributor Author

srimanob commented Mar 4, 2023

test parameters:

@srimanob
Copy link
Contributor Author

srimanob commented Mar 4, 2023

test parameters:

  • workflow = 14034.0
  • relvals_opt = --what upgrade,standard,highstats,pileup,generator,extendedgen,production,ged,machine,premix,nano,gpu

@srimanob
Copy link
Contributor Author

srimanob commented Mar 4, 2023

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-5af89d/31062/summary.html
COMMIT: 5c97335
CMSSW: CMSSW_13_1_X_2023-03-03-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40954/31062/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 17 lines from the logs
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3529727
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3529701
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor Author

srimanob commented Mar 4, 2023

FYI @sbein

@srimanob
Copy link
Contributor Author

srimanob commented Mar 4, 2023

+Upgrade

Note that, the PU FastSim will be added when 2023 FastSim MinBias will be available, ETA after 13_1_0_pre2 is available.

@kskovpen
Copy link
Contributor

kskovpen commented Mar 4, 2023

+pdmv

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 4, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Mar 4, 2023

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants