Migrate consumesMany to GetterOfProducts in DQMServices

[jeongeun]

PR description:

Based on PR #40167 .
Migrate DQMServices core codes away from consumesMany() to use edm::GetterOfProducts().

    modified:   DQMServices/Components/plugins/MEtoEDMConverter.cc
    modified:   DQMServices/FileIO/plugins/DQMFileSaverBase.cc
    modified:   DQMServices/FileIO/plugins/DQMFileSaverBase.h

PR validation:

Tested in CMSSW_13_0_0_pre4, the basic test passed in the CMSSW PR instructions

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40958/34446

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @jeongeun (JeongEun Lee) for master.

It involves the following packages:

• DQMServices/Components (dqm)
• DQMServices/FileIO (dqm)

@emanueleusai, @cmsbuild, @syuvivida, @rvenditti, @micsucmed, @pmandrik can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[emanueleusai]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-470c5d/31084/summary.html
COMMIT: f33f491
CMSSW: CMSSW_13_1_X_2023-03-05-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40958/31084/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 4 lines from the logs
• Reco comparison results: 3 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3529727
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3529701
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[mmusich]

test parameters:

• workflows = 1001.2, 1001.3, 1002.3, 1002.4, 1052, 1052.1
• addpkg = CalibTracker/SiStripChannelGain

[mmusich]

@cmsbuild, please test

• DQM legacy code is used all over the place in alca, hoping to test as much as possible in Migrate consumesMany to GetterOfProducts in DQMServices #40958 (comment)

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-470c5d/31095/summary.html
COMMIT: f33f491
CMSSW: CMSSW_13_1_X_2023-03-06-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40958/31095/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 3 lines to the logs
• Reco comparison results: 8 differences found in the comparisons
• DQMHistoTests: Total files compared: 55
• DQMHistoTests: Total histograms compared: 3662049
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3662021
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 54 files compared)
• Checked 238 log files, 169 edm output root files, 55 DQM output files
• TriggerResults: no differences found

[emanueleusai]

+1

• dqm differences in HLT/SiStrip/ControlView and EgammaV/ConversionValidator/ConversionInfo are unrelated to this PR

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1