Final clang fix.

[ktf]

Fixes complain about:

.../xr.cc: error: explicit specialization of 'fgIsA' after instantiation
template<> atomic_TClass_ptr TFWLiteSelector<XXXX>::fgIsA(0);
                                             ^
.../xr.cc:111:9: note: implicit instantiation first required here

[cmsbuild]

A new Pull Request was created by @ktf (Giulio Eulisse) for CMSSW_7_2_X.

Final clang fix.

It involves the following packages:

FWCore/TFWLiteSelectorTest
PhysicsTools/ParallelAnalysis

@nclopezo, @monttj, @cmsbuild, @Dr15Jones, @vadler, @Degano, @ktf can you please review it and eventually sign? Thanks.
@wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[cmsbuild]

-1
I found an error when building:

Entering library rule at FWCore/Version
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-06-03-0200/src/FWCore/TFWLiteSelectorTest/src/ThingsTSelector.cc 
>> Compiling  /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-06-03-0200/src/FWCore/TFWLiteSelectorTest/src/ThingsTSelector2.cc 
>> Building LCG reflex dict from header file src/FWCore/TFWLiteSelectorTest/src/classes.h
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-06-03-0200/src/PhysicsTools/ParallelAnalysis/src/TrackAnalysisAlgorithm.cc:1:0:
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_2_X-slc6_amd64_gcc481/CMSSW_7_2_X_2014-06-03-0200/src/PhysicsTools/ParallelAnalysis/interface/TrackAnalysisAlgorithm.h:39:12: error: 'atomic_TClass_ptr' does not name a type
 template<> atomic_TClass_ptr TFWLiteSelectorexamples::TrackAnalysisAlgorithm::fgIsA;
            ^
--->> genreflex: INFO: Parsing file src/FWCore/TFWLiteSelectorTest/src/classes.h with GCC_XML OK
--->> genreflex: INFO: Generating Reflex Dictionary
class TFWLiteSelectortfwliteselectortest::ThingsWorker


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4096/48/summary.html

[cmsbuild]

Pull request #4096 was updated. @nclopezo, @monttj, @cmsbuild, @Dr15Jones, @vadler, @Degano, @ktf can you please check and sign again.

[cmsbuild]

+1
Tested at: c5c0b4a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4096/110/summary.html

[ktf]

+1

Bypassing AT signature. Complain if not ok.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4096/110/summary.html