Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT menu development for 13_0_X (3/N) [13_1_X] #40965

Merged
merged 1 commit into from Mar 7, 2023

Conversation

missirol
Copy link
Contributor

@missirol missirol commented Mar 6, 2023

PR description:

Development of HLT menus for CMSSW_13_0_X.

This is the PR for the master branch, which will then be backported to 13_0_X (the latter is the release cycle currently used for Run-3 HLT-menu development).

This PR includes the integration of the following JIRA tickets.

  • CMSHLT-2531: [HIG] use tighter DeepJet b-tag wp in MSSM-Hbb triggers
  • CMSHLT-2606: [PPS] add ExpressPPSRandom stream and PD
  • CMSHLT-2631: [EXO] add 2 diphoton backup triggers to GRun
  • CMSHLT-2641: [TSG] removed unused global PSets (post Run2022)
  • CMSHLT-2642: [TSG] set PS=0 for all MC Paths in all PS columns
  • CMSHLT-2643: [EXO] add eta restriction to delayed-DiPhoton10 triggers
  • CMSHLT-2647: [TSG] removed CUDAService module
  • CMSHLT-2648: [HCAL] remove HLTHcalCalibTypeFilter module from HLT_HcalCalibration_v trigger

It also includes the migration of the HLT menus ("Fake*", frozen, and development ones) to the ConfDB template for CMSSW_13_0_0.

PR validation:

TSG tests.

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

CMSSW_13_0_X

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40965/34465

  • This PR adds an extra 808KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 6, 2023

A new Pull Request was created by @missirol (Marino Missiroli) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

missirol commented Mar 6, 2023

enable gpu

@missirol
Copy link
Contributor Author

missirol commented Mar 6, 2023

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-690335/31107/summary.html
COMMIT: 6bc4312
CMSSW: CMSSW_13_1_X_2023-03-06-1100/el8_amd64_gcc11
Additional Tests: GPU
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40965/31107/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3529718
  • DQMHistoTests: Total failures: 50
  • DQMHistoTests: Total nulls: 12
  • DQMHistoTests: Total successes: 3529634
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 377.512 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 61.269 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 11634.0,... ): 1.414 KiB HLT/Filters
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 6 / 47 workflows

GPU Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 3 differences found in the comparisons
  • DQMHistoTests: Total files compared: 4
  • DQMHistoTests: Total histograms compared: 19862
  • DQMHistoTests: Total failures: 10
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 19852
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 3 files compared)
  • Checked 12 log files, 9 edm output root files, 4 DQM output files
  • TriggerResults: found differences in 3 / 3 workflows

@missirol
Copy link
Contributor Author

missirol commented Mar 7, 2023

+hlt

Changes in the outputs of PR tests are in line with updates to the HLT GRun menu, and the change in name of the frozen/fake HLT menus.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Mar 7, 2023

+1

@cmsbuild cmsbuild merged commit 3d0f0e3 into cms-sw:master Mar 7, 2023
13 checks passed
@missirol missirol deleted the HLTdevelopment130X_for131X branch March 7, 2023 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants