Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to Skim Unused Input Prototracks #40983

Merged
merged 2 commits into from Mar 9, 2023

Conversation

AdrianoDee
Copy link
Contributor

PR description:

This PR allows, via the produceComplement flag, to put in the event the tracks not used to produce the TrajectorySeedCollection in SeedGeneratorFromProtoTracksEDProducer. May be beneficial, e.g., if we want to reuse the discarded pixel tracks at HLT for PUPPI (investigations ongoing).

PR validation:

Tests run. Technical PR.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2023

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40983/34490

  • This PR adds an extra 12KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40983/34492

  • This PR adds an extra 12KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2023

A new Pull Request was created by @AdrianoDee (Adriano Di Florio) for master.

It involves the following packages:

  • RecoTracker/TkSeedGenerator (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@VourMa, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @missirol, @gpetruc, @mmusich, @mtosi, @dgulhan this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@AdrianoDee
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-545a65/31128/summary.html
COMMIT: 0ddcdd5
CMSSW: CMSSW_13_1_X_2023-03-07-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40983/31128/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-545a65/31128/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-545a65/31128/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 10 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 18 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3529718
  • DQMHistoTests: Total failures: 56
  • DQMHistoTests: Total nulls: 12
  • DQMHistoTests: Total successes: 3529628
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 377.512 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 61.269 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 11634.0,... ): 1.414 KiB HLT/Filters
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 6 / 47 workflows

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Mar 9, 2023

+1

@cmsbuild cmsbuild merged commit 2f43eca into cms-sw:master Mar 9, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants