Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use anonymous namespace in CandIsolatorFromDeposits #40984

Merged

Conversation

Dr15Jones
Copy link
Contributor

PR description:

This appears to avoid an ASAN error when used with LTO.

PR validation:

Building and running in the ASAN IB now allows the 1.0 step3 workflow to run.

This appears to avoid an ASAN error when used with LTO.
@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40984/34491

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2023

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

  • PhysicsTools/IsolationAlgos (reconstruction)

@cmsbuild, @mandrenguyen, @clacaputo can you please review it and eventually sign? Thanks.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@Dr15Jones
Copy link
Contributor Author

please test

@dan131riley
Copy link

I tested with step1 of wf 5.1, and it worked there too. Do not understand at all why it fixes it.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2023

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65f126/31127/summary.html
COMMIT: 1b2a30d
CMSSW: CMSSW_13_1_X_2023-03-07-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40984/31127/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65f126/31127/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65f126/31127/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

  • You potentially removed 9 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3529718
  • DQMHistoTests: Total failures: 51
  • DQMHistoTests: Total nulls: 12
  • DQMHistoTests: Total successes: 3529633
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 377.512 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 61.269 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 11634.0,... ): 1.414 KiB HLT/Filters
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 6 / 47 workflows

@Dr15Jones
Copy link
Contributor Author

The failing test had the message

2023/03/07 19:34:19 ERROR failed to parse X509 proxy: crypto/tls: failed to parse key: asn1: syntax error: data truncated

which could not have been from this change.

@Dr15Jones
Copy link
Contributor Author

please test

let's see if this can just clear the spurious failure.

@makortel
Copy link
Contributor

makortel commented Mar 7, 2023

@cmsbuild, please test for CMSSW_13_1_ASAN_X

let's see the ASAN as well

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65f126/31135/summary.html
COMMIT: 1b2a30d
CMSSW: CMSSW_13_1_X_2023-03-07-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40984/31135/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65f126/31135/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65f126/31135/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 10 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3529718
  • DQMHistoTests: Total failures: 53
  • DQMHistoTests: Total nulls: 12
  • DQMHistoTests: Total successes: 3529631
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 377.512 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 61.269 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 11634.0,... ): 1.414 KiB HLT/Filters
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 6 / 47 workflows

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2023

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65f126/31136/summary.html
COMMIT: 1b2a30d
CMSSW: CMSSW_13_1_ASAN_X_2023-03-06-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40984/31136/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65f126/31136/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-65f126/31136/git-merge-result

Unit Tests

I found errors in the following unit tests:

---> test GCPall had ERRORS
---> test SubmitPVrbr had ERRORS
---> test SubmitPVsplit had ERRORS
---> test JetHTall had ERRORS
and more ...

@smuzaffar
Copy link
Contributor

@cms-sw/reconstruction-l2 can you please review this? This should fix the massive ASAN relval errors (please ignore the ASAN unit tests errors #40984 (comment))

@clacaputo
Copy link
Contributor

+reconstruction

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Mar 8, 2023

+1

@cmsbuild cmsbuild merged commit d1db54c into cms-sw:master Mar 8, 2023
16 of 17 checks passed
@smuzaffar
Copy link
Contributor

thanks a lot for quick action, I have triggered a 13h00 ASAN IB to test this change

@Dr15Jones Dr15Jones deleted the namespaceCandIsolatorFromDeposits branch March 17, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants