Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add plugin to use existing HLTDoubleSinglet module with two PFJets and one RecoEcalCandidate #40994

Merged
merged 1 commit into from Mar 8, 2023
Merged

Add plugin to use existing HLTDoubleSinglet module with two PFJets and one RecoEcalCandidate #40994

merged 1 commit into from Mar 8, 2023

Conversation

brallmond
Copy link
Contributor

PR description:

To support future VBF Electron and VBF Photon HLTs in the scenario that VBF Parking is accepted (see JIRA https://its.cern.ch/jira/browse/CMSLITDPG-1099), one plugin is added to the existing plugins file of HLTrigger/HLTfilters.

PR validation:

With the changed file in place, the rates of VBF Electron and VBF Photon were estimated after changing by-hand the EDFilter type to use for the final filter of each path. It was found that events pass both paths and use the triplet filter in the expected way (cross-cleaning a RecoEcalCandidate from two PFJets).

NB: It wasn't obvious to me this was the case at first, but using the same EDFilter module for both electrons and photons is in-line with existing HLT paths and code (see the Ele-Tau cross trigger, which uses a HLT2PhotonTau EDFilter in its cross-cleaning module, hltOverlapFilterIsoEle24IsoTau30WPTightGsfCaloJet5).

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40994/34506

  • This PR adds an extra 8KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2023

A new Pull Request was created by @brallmond (Braden Allmond) for master.

It involves the following packages:

  • HLTrigger/HLTfilters (hlt)

@cmsbuild, @missirol, @Martin-Grunewald can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @silviodonato this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor

missirol commented Mar 8, 2023

please test

@missirol
Copy link
Contributor

missirol commented Mar 8, 2023

@brallmond , the title of this PR is truncated, please fix it.

Then, please update the title of the backport PR accordingly, e.g. title of backport = "(title of this PR) [13_0_X]").

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-96fa16/31141/summary.html
COMMIT: 107b4b5
CMSSW: CMSSW_13_1_X_2023-03-08-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40994/31141/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 19 lines from the logs
  • Reco comparison results: 14 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3530381
  • DQMHistoTests: Total failures: 10
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3530349
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

missirol commented Mar 8, 2023

+hlt

Adds an HLT filter currently unused in any central wf.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@brallmond brallmond changed the title add plugin to use existing HLTDoubleSinglet module with two PFJets an… Add plugin to use existing HLTDoubleSinglet module with two PFJets and one RecoEcalCandidate Mar 8, 2023
@perrotta
Copy link
Contributor

perrotta commented Mar 8, 2023

+1

@cmsbuild cmsbuild merged commit 9cb7ecf into cms-sw:master Mar 8, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants