New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CORE] Various fixes/improvements for unit test #40997
Conversation
@Dr15Jones , @makortel many of these |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40997/34510
|
A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master. It involves the following packages:
@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
Yeah, those tests are ancient and written by a person who really wasn't a CMS developer (he was the original FNAL message logger developer). Consolidating them makes a lot of sense. |
I agree. @smuzaffar Would you like to pursue the consolidation already in this PR? |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2b213/31145/summary.html Comparison SummarySummary:
|
@makortel , no not in this PR. I can do it in a new PR (after I am done with unit test changes to allow them to run from separate test directory/per test) |
A single-histogram difference in 11634.7 is presumably realted to #39803 |
+1 |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Updated unit tests so that they can be run from their own separate directory. Mostly
<bin ...>
to<test....>
SCRAM_TEST_PATH
insteadthese changes will allow to run unit tests in separate unit test directories.