Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE] Various fixes/improvements for unit test #40997

Merged
merged 1 commit into from Mar 9, 2023

Conversation

smuzaffar
Copy link
Contributor

Updated unit tests so that they can be run from their own separate directory. Mostly

  • convert <bin ...> to <test....>
  • make use of SCRAM_TEST_PATH instead
  • cleanup unused unittest driver files

these changes will allow to run unit tests in separate unit test directories.

@smuzaffar
Copy link
Contributor Author

@Dr15Jones , @makortel many of these FWCore/MessageService/test/u*.sh files are similar. I think we can merge most of these in two a single script and run it with different input parameters e.g. runtest.sh <num> .

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2023

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40997/34510

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2023

A new Pull Request was created by @smuzaffar (Malik Shahzad Muzaffar) for master.

It involves the following packages:

  • FWCore/MessageService (core)

@cmsbuild, @smuzaffar, @Dr15Jones, @makortel can you please review it and eventually sign? Thanks.
@makortel, @missirol, @wddgit this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@smuzaffar
Copy link
Contributor Author

please test

@Dr15Jones
Copy link
Contributor

many of these FWCore/MessageService/test/u*.sh files are similar.

Yeah, those tests are ancient and written by a person who really wasn't a CMS developer (he was the original FNAL message logger developer). Consolidating them makes a lot of sense.

@makortel
Copy link
Contributor

makortel commented Mar 8, 2023

many of these FWCore/MessageService/test/u*.sh files are similar.

Yeah, those tests are ancient and written by a person who really wasn't a CMS developer (he was the original FNAL message logger developer). Consolidating them makes a lot of sense.

I agree. @smuzaffar Would you like to pursue the consolidation already in this PR?

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2023

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d2b213/31145/summary.html
COMMIT: 1a96da3
CMSSW: CMSSW_13_1_X_2023-03-08-1300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/40997/31145/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 7 lines to the logs
  • Reco comparison results: 6 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3530381
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3530352
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@smuzaffar
Copy link
Contributor Author

I agree. @smuzaffar Would you like to pursue the consolidation already in this PR?

@makortel , no not in this PR. I can do it in a new PR (after I am done with unit test changes to allow them to run from separate test directory/per test)

@makortel
Copy link
Contributor

makortel commented Mar 8, 2023

A single-histogram difference in 11634.7 is presumably realted to #39803

@makortel
Copy link
Contributor

makortel commented Mar 8, 2023

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 8, 2023

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

perrotta commented Mar 9, 2023

+1

@cmsbuild cmsbuild merged commit 28df1c4 into cms-sw:master Mar 9, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants