Cleanup and preparation for sim extentions

[civanch]

PR description:

Number of reorganisations inside Geant4 user actions and elements of code guideline in some classes. The main purpose is to make further R&D efforts easier. Tracking, Stepping and Stacking action use SimTrackManager directly and not EventAction as an intermediate object.

No change in any WF is expected.

PR validation:

private

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for: NO

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41022/34548

• This PR adds an extra 52KB to repository

[cmsbuild]

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for master.

It involves the following packages:

• SimG4Core/Application (simulation)
• SimG4Core/Notification (simulation)
• SimG4Core/SaveSimTrackAction (simulation)
• SimG4Core/Watcher (simulation)

@cmsbuild, @civanch, @mdhildreth can you please review it and eventually sign? Thanks.
@makortel, @bsunanda, @rovere, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[civanch]

please test

[cmsbuild]

-1

Failed Tests: Build
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-797580/31196/summary.html
COMMIT: 538da48
CMSSW: CMSSW_13_1_X_2023-03-10-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41022/31196/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-10-1100/src/SimG4Core/CustomPhysics/plugins/RHStopDump.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-10-1100/src/SimG4Core/CustomPhysics/plugins/DBremWatcher.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-10-1100/src/SimG4Core/CustomPhysics/plugins/RHStopTracer.cc
>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-10-1100/src/SimG4Core/CustomPhysics/plugins/module.cc
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-10-1100/src/SimG4Core/CustomPhysics/plugins/DBremWatcher.cc: In member function 'virtual void DBremWatcher::update(const BeginOfTrack*)':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-10-1100/src/SimG4Core/CustomPhysics/plugins/DBremWatcher.cc:66:30: error: no matching function for call to 'TrackInformation::storeTrack(bool)'
   66 |           trkInfo->storeTrack(true);
      |           ~~~~~~~~~~~~~~~~~~~^~~~~~
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-10-1100/src/SimG4Core/CustomPhysics/plugins/DBremWatcher.cc:7:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-10-1100/src/SimG4Core/Notification/interface/TrackInformation.h:18:8: note: candidate: 'bool TrackInformation::storeTrack() const'
   18 |   bool storeTrack() const { return storeTrack_; }


[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41022/34550

• This PR adds an extra 52KB to repository

[cmsbuild]

Pull request #41022 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41022/34586

• This PR adds an extra 80KB to repository

[cmsbuild]

Pull request #41022 was updated. @cmsbuild, @civanch, @mdhildreth can you please check and sign again.

[civanch]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-797580/31240/summary.html
COMMIT: 425d713
CMSSW: CMSSW_13_1_X_2023-03-12-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41022/31240/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3550756
• DQMHistoTests: Total failures: 5
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3550729
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1