Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MTD geometry: update tests to scenario D95 #41026

Merged
merged 2 commits into from Mar 13, 2023

Conversation

fabiocos
Copy link
Contributor

PR description:

In all (unit) test configurations used for MTD geometry scrutiny, the default scenario to be used is moved to D95, following the proposed update of the default for general tests. The test of the BTL RectangularMTDTopology is at the same time extended to probe the conversion from module to crystal reference frame.

This update requires also the update of the unit test reference files in cms-data/Geometry-TestReference.

PR validation:

The code is running, and it has been used to produce the references. The additional test is showing no error.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41026/34554

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fabiocos (Fabio Cossutti) for master.

It involves the following packages:

  • Geometry/MTDCommonData (geometry, upgrade)
  • Geometry/MTDGeometryBuilder (geometry, upgrade)
  • Geometry/MTDNumberingBuilder (geometry, upgrade)
  • RecoMTD/DetLayers (upgrade, reconstruction)
  • Validation/Geometry (geometry, dqm)
  • Validation/MtdValidation (dqm)

@civanch, @Dr15Jones, @bsunanda, @makortel, @micsucmed, @emanueleusai, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @clacaputo, @syuvivida, @pmandrik, @mandrenguyen, @rvenditti can you please review it and eventually sign? Thanks.
@youyingli, @apsallid, @bsunanda, @vargasa, @rovere, @missirol, @ebrondol, @rishabhCMS, @rbartek this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@fabiocos
Copy link
Contributor Author

please test with cms-data/Geometry-TestReference#12

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7c55d/31203/summary.html
COMMIT: 1605443
CMSSW: CMSSW_13_1_X_2023-03-10-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41026/31203/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7c55d/31203/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7c55d/31203/git-merge-result

Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 81 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3525859
  • DQMHistoTests: Total failures: 979
  • DQMHistoTests: Total nulls: 95
  • DQMHistoTests: Total successes: 3524763
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 76692.92400000001 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 9818.210 KiB HLT/BTV
  • DQMHistoSizes: changed ( 11634.0,... ): 1531.818 KiB HLT/EXO
  • DQMHistoSizes: changed ( 11634.0,... ): 1187.008 KiB HLT/TOP
  • DQMHistoSizes: changed ( 11634.0,... ): 1130.035 KiB HLT/HIG
  • DQMHistoSizes: changed ( 11634.0,... ): 1056.366 KiB HLT/JME
  • DQMHistoSizes: changed ( 11634.0,... ): 344.597 KiB HLT/Objects
  • DQMHistoSizes: changed ( 11634.0,... ): 152.027 KiB HLT/TAU
  • DQMHistoSizes: changed ( 11634.0,... ): 117.172 KiB HLT/EGM
  • DQMHistoSizes: changed ( 11634.0,... ): -57.377 KiB HLT/Filters
  • DQMHistoSizes: changed ( 11634.0,... ): 36.644 KiB HLT/Exotica
  • DQMHistoSizes: changed ( 11634.0 ): ...
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 6 / 47 workflows

@bsunanda
Copy link
Contributor

+geometry

@srimanob
Copy link
Contributor

@cmsbuild please test

Let's make the clean PR test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7c55d/31217/summary.html
COMMIT: 1605443
CMSSW: CMSSW_13_1_X_2023-03-10-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41026/31217/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found errors in the following unit tests:

---> test GeometryMTDGeometryBuilderTestDriver had ERRORS
---> test GeometryMTDNumberingBuilderTestDriver had ERRORS
---> test RecoMTDDetLayersTestDriver had ERRORS
---> test GeometryMTDCommonDataTestDriver had ERRORS
and more ...

Comparison Summary

Summary:

  • You potentially added 8 lines to the logs
  • Reco comparison results: 21 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3550756
  • DQMHistoTests: Total failures: 123
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3550611
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@fabiocos
Copy link
Contributor Author

please test with cms-data/Geometry-TestReference#12

@srimanob withou the external update, the unit tests are bound to fail

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7c55d/31219/summary.html
COMMIT: 1605443
CMSSW: CMSSW_13_1_X_2023-03-10-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41026/31219/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7c55d/31219/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7c55d/31219/git-merge-result

Comparison Summary

Summary:

  • No significant changes to the logs found
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 8 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3550756
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3550728
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@srimanob
Copy link
Contributor

+Upgrade

@emanueleusai
Copy link
Member

+1

@mandrenguyen
Copy link
Contributor

+reconstruction

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@fabiocos
Copy link
Contributor Author

@cms-sw/orp-l2 please recall to merge in parallel the external cms-data/Geometry-TestReference#12 at the time of the integration

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e043b5d into cms-sw:master Mar 13, 2023
11 checks passed
@fabiocos fabiocos deleted the fc-geomupdate20230310 branch March 22, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants