New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTD geometry: update tests to scenario D95 #41026
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41026/34554
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages:
@civanch, @Dr15Jones, @bsunanda, @makortel, @micsucmed, @emanueleusai, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @clacaputo, @syuvivida, @pmandrik, @mandrenguyen, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test with cms-data/Geometry-TestReference#12 |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7c55d/31203/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
+geometry |
@cmsbuild please test Let's make the clean PR test |
-1 Failed Tests: UnitTests Unit TestsI found errors in the following unit tests: ---> test GeometryMTDGeometryBuilderTestDriver had ERRORS ---> test GeometryMTDNumberingBuilderTestDriver had ERRORS ---> test RecoMTDDetLayersTestDriver had ERRORS ---> test GeometryMTDCommonDataTestDriver had ERRORS and more ... Comparison SummarySummary:
|
please test with cms-data/Geometry-TestReference#12 @srimanob withou the external update, the unit tests are bound to fail |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e7c55d/31219/summary.html The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:
You can see more details here: Comparison SummarySummary:
|
+Upgrade |
+1 |
+reconstruction |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
@cms-sw/orp-l2 please recall to merge in parallel the external cms-data/Geometry-TestReference#12 at the time of the integration |
+1 |
PR description:
In all (unit) test configurations used for MTD geometry scrutiny, the default scenario to be used is moved to D95, following the proposed update of the default for general tests. The test of the BTL RectangularMTDTopology is at the same time extended to probe the conversion from module to crystal reference frame.
This update requires also the update of the unit test reference files in
cms-data/Geometry-TestReference
.PR validation:
The code is running, and it has been used to produce the references. The additional test is showing no error.