New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MTD digitization: add position dependence to BTL amplitudes #41027
Conversation
…iPMs, add histograms in validation to monitor it
…t is already included
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41027/34556
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41027/34557
|
A new Pull Request was created by @fabiocos (Fabio Cossutti) for master. It involves the following packages:
@civanch, @emanueleusai, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @syuvivida, @pmandrik, @micsucmed, @rvenditti can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-586f5b/31212/summary.html Comparison SummarySummary:
|
+1 |
Are differences from PR test expected, @fabiocos ? Thx. |
@srimanob I would say so. As you can see, I have added a smearing to the amplitude that was not there before for BTL, this is clearly changing the random number history for the digitization of MTD, and it reflects on the changes observed, which will trigger small changes in whatever is using it. The change in the amplitudes at the two SiPMs does not trigger big observable changes because only this PR is adding histograms to monitor this, and because in the reconstruction the final result is anyway an average, which should keep things unchanged. |
+1 |
@srimanob @cms-sw/orp-l2 this PR might conflict with #41083 by @ctarricone . I would suggest to move forward earlier with this one, while finalizing the newest code, and then rebase that on top of this, if needed. |
@cms-sw/upgrade-l2 is there any further question/doubt about this PR? |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
Well, having not noticed a similar warning in #41083 I already merged that one first... Let merge also this one, but please @fabiocos have a look whether some hidden conflict that you are aware of actually showed up |
+1 |
@perrotta according to git everything looked ok, I'll have a look at the status of the code, but presumably it is ok also in this way, thanks |
PR description:
This PR is based on the update of the BTL digitization discussed in https://indico.cern.ch/event/1254512/contributions/5270125/attachments/2595148/4479504/MTDDPG_BTL_position_20230217.pdf . A position dependence of the amplitude measured in the sensors at the two extremities of the crystal is introduced, with values from tunable parameters, currently from BTL test beam studies.
The BTL digitization validation is updated accordingly to monitor this effect.
PR validation:
The code has been used to produce the results shown in the presentation above