Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the beam spot configuration of the Phase-2 HLT menu more consistent #41047

Merged
merged 1 commit into from Mar 14, 2023

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Mar 13, 2023

PR description:

Make the beam spot configuration of the Phase-2 HLT menu more consistent.

Currently, part of the modules use the offlineBeamSpotProducer, and part use the hltOnlineBeamSpotProducer.
Moreover it is not clear if the hltOnlineBeamSpotProducer is working correctly in the Phase-2 configuration.

These changes:

  • remove the hltScalersRawToDigi and hltOnlineBeamSpotProducer modules;
  • rename the offlineBeamSpotProducer module to hltOnlineBeamSpotProducer;
  • replace explicit instances of the hltOnlineBeamSpotProducer with the HLTBeamSpotTask;
  • update all modules to use the hltOnlineBeamSpotProducer as input.

PR validation:

runTheMAtrix.py -l 20834.76 runs.

Note that this PR builds on top, and so includes, #40912 .

These changes
  - remove the hltScalersRawToDigi and hltOnlineBeamSpotProducer modules;
  - rename the offlineBeamSpotProducer module to hltOnlineBeamSpotProducer;
  - replace explicit instances of the hltOnlineBeamSpotProducer with the HLTBeamSpotTask;
  - update all modules to use the hltOnlineBeamSpotProducer as input.
@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 13, 2023

please test

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41047/34610

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for master.

It involves the following packages:

  • HLTrigger/Configuration (hlt)

@Martin-Grunewald, @missirol can you please review it and eventually sign? Thanks.
@rchatter, @SohamBhattacharya, @argiro, @Martin-Grunewald, @missirol, @silviodonato, @thomreis, @simonepigazzini, @beaucero this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-42a88d/31254/summary.html
COMMIT: fdc5c66
CMSSW: CMSSW_13_1_X_2023-03-13-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41047/31254/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 12 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 410 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3550756
  • DQMHistoTests: Total failures: 4
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3550730
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@beaucero
Copy link
Contributor

It has been discussed at the HLT Upgrade meeting and it is agreed to get in

@missirol
Copy link
Contributor

+hlt

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@missirol
Copy link
Contributor

(The first 3 of the 4 commits are already in master due to #40912. GitHub still shows 4 commits in this PR, but I guess this only a feature of the webpage. A possible workaround is discussed here, but I think this PR can be merged regardless.)

@fwyzard fwyzard changed the base branch from master to CMSSW_13_1_X March 14, 2023 18:48
@fwyzard fwyzard changed the base branch from CMSSW_13_1_X to master March 14, 2023 18:48
@fwyzard
Copy link
Contributor Author

fwyzard commented Mar 14, 2023

I forced github to re-evaluate the merge, now it shows a single commit.

@rappoccio
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants