Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply Tracker Alignment to phase2 geometries #41075

Merged
merged 2 commits into from Mar 20, 2023

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Mar 16, 2023

PR description:

This PR is complementary to #41072.
In that PR the Tracker Alignment records from the Phase2 simulation GlobalTags were removed, since these are currently using Phase-1 conditions.
This PR, in turn, aims to supply to the Phase-2 workflows geometry-dependent aligned IDEAL geometries, by introducing appropriate dictionaries in autoCondPhase2.py for TrackerAlignmentRcd, TrackerAlignmentErrorExtendedRcd, TrackerSurfaceDeformationRcd.
At the same time the applyAlignment parameter of TrackerDigiGeometryESModule is set to True for all active Phase-2 geometries (and correspondingly in dict2026Geometry in order to pass unit tests).
The aim is to further develop Tracker Alignment related workflows for the Phase-2 upgrade detector.

PR validation:

Successfully run: runTheMatrix.py -l 20834.0 -j 8 --ibeos
Multi Track Validator comparison at http://musich.web.cern.ch/musich/display/PR_41075_validation_1k/plots_ootb.html (1k events of 20800.0: FourMuPt1_200+2026D8)

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

cc:
@consuegs @henriettepetersen @emiglior

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41075/34688

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mmusich (Marco Musich) for master.

It involves the following packages:

  • Configuration/AlCa (alca)
  • Configuration/Geometry (geometry, upgrade)

@civanch, @Dr15Jones, @bsunanda, @makortel, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @saumyaphor4252, @tvami, @francescobrivio can you please review it and eventually sign? Thanks.
@vargasa, @kpedro88, @Martin-Grunewald, @missirol, @tocheng, @mmusich, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Mar 16, 2023

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3cec15/31338/summary.html
COMMIT: b384fde
CMSSW: CMSSW_13_1_X_2023-03-16-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41075/31338/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 18 lines to the logs
  • Reco comparison results: 367 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3550819
  • DQMHistoTests: Total failures: 6139
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3544658
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 213 log files, 164 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented Mar 17, 2023

Everything looks good, shall this PR be moved away from being a draft?

@bsunanda
Copy link
Contributor

+geometry

@srimanob
Copy link
Contributor

Hi @mmusich @tvami
Could you please turn the draft to PR? Thx.

@mmusich mmusich marked this pull request as ready for review March 17, 2023 09:15
@tvami
Copy link
Contributor

tvami commented Mar 18, 2023

+alca

  • PR according to description
  • tests pass, changes are visible and expected

@mmusich
Copy link
Contributor Author

mmusich commented Mar 20, 2023

any comment from @cms-sw/upgrade-l2 ?

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants