New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply Tracker Alignment to phase2 geometries #41075
Conversation
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41075/34688
|
A new Pull Request was created by @mmusich (Marco Musich) for master. It involves the following packages:
@civanch, @Dr15Jones, @bsunanda, @makortel, @mdhildreth, @cmsbuild, @AdrianoDee, @srimanob, @saumyaphor4252, @tvami, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3cec15/31338/summary.html Comparison SummarySummary:
|
Everything looks good, shall this PR be moved away from being a draft? |
+geometry |
+alca
|
any comment from @cms-sw/upgrade-l2 ? |
+Upgrade |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
Fix several unit test post-merge of #41075
PR description:
This PR is complementary to #41072.
In that PR the Tracker Alignment records from the Phase2 simulation GlobalTags were removed, since these are currently using Phase-1 conditions.
This PR, in turn, aims to supply to the Phase-2 workflows geometry-dependent aligned IDEAL geometries, by introducing appropriate dictionaries in
autoCondPhase2.py
forTrackerAlignmentRcd
,TrackerAlignmentErrorExtendedRcd
,TrackerSurfaceDeformationRcd
.At the same time the
applyAlignment
parameter ofTrackerDigiGeometryESModule
is set toTrue
for all active Phase-2 geometries (and correspondingly indict2026Geometry
in order to pass unit tests).The aim is to further develop Tracker Alignment related workflows for the Phase-2 upgrade detector.
PR validation:
Successfully run:
runTheMatrix.py -l 20834.0 -j 8 --ibeos
Multi Track Validator comparison at http://musich.web.cern.ch/musich/display/PR_41075_validation_1k/plots_ootb.html (1k events of 20800.0: FourMuPt1_200+2026D8)
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A
cc:
@consuegs @henriettepetersen @emiglior