Move leftover PoolDBOutputService modules to use kSharedResource

[tvami]

PR description:

Last piece to resolve #18340, BoostIODBWriter<>, and DummyCondDBWriter<> are now using SharedResources for accessing the DB.

A few cosmetics changes:

• fixing how LogInfo() should work (which to me actually seems like it should have been LogDebug(), but I didnt change to that)
• Alpha order the include statements

PR validation:

code compiles, unit tests scram b runtests pass

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport and no backport is needed

[tvami]

@cmsbuild , please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41094/34713

• This PR adds an extra 20KB to repository

[cmsbuild]

A new Pull Request was created by @tvami (Tamas Vami) for master.

It involves the following packages:

• CalibTracker/SiStripESProducers (alca)
• CommonTools/ConditionDBWriter (db)
• CondTools/Hcal (db)

@tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@echabert, @robervalwalsh, @gbenelli, @tocheng, @missirol, @mmusich this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

-1

Failed Tests: Build HeaderConsistency
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-480837/31390/summary.html
COMMIT: 43aa1d7
CMSSW: CMSSW_13_1_X_2023-03-17-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41094/31390/install.sh to create a dev area with all the needed externals and cmssw changes.

Build

I found compilation error when building:

>> Compiling edm plugin /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-17-2300/src/CondTools/SiPhase2Tracker/plugins/SiPhase2OuterTrackerLorentzAngleWriter.cc
In file included from /data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-17-2300/src/CondTools/SiPhase2Tracker/plugins/SiPhase2BadStripChannelBuilder.cc:8:
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-17-2300/src/CommonTools/ConditionDBWriter/interface/ConditionDBWriter.h:309:13: warning: missing terminating " character
  309 |             "
      |             ^
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-17-2300/src/CommonTools/ConditionDBWriter/interface/ConditionDBWriter.h:309:13: error: missing terminating " character
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-17-2300/src/CommonTools/ConditionDBWriter/interface/ConditionDBWriter.h: In member function 'void ConditionDBWriter::endJob()':
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-17-2300/src/CommonTools/ConditionDBWriter/interface/ConditionDBWriter.h:307:13: error: expected ';' before ':' token
  307 |             : ERROR - requested to store on DB on a Job based interval,
      |             ^
/data/cmsbld/jenkins/workspace/ib-run-pr-tests/CMSSW_13_1_X_2023-03-17-2300/src/CommonTools/ConditionDBWriter/interface/ConditionDBWriter.h: In instantiation of 'void ConditionDBWriter::endJob() [with T = SiStripBadStrip]':


[tvami]

@cmsbuild , please test

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41094/34715

• This PR adds an extra 20KB to repository

[cmsbuild]

Pull request #41094 was updated. @tvami, @saumyaphor4252, @francescobrivio can you please check and sign again.

[cmsbuild]

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-480837/31396/summary.html
COMMIT: 31c9269
CMSSW: CMSSW_13_1_X_2023-03-18-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41094/31396/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

• You potentially removed 1 lines from the logs
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3550882
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3550856
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tvami]

@cmsbuild please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-480837/31402/summary.html
COMMIT: 31c9269
CMSSW: CMSSW_13_1_X_2023-03-18-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41094/31402/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 6 lines from the logs
• Reco comparison results: 5 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3550882
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3550854
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[saumyaphor4252]

+1

• tests pass, diffs only in MsgLogger

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1