Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HI 2023 relval wfs + realistic 2022 vtx smearing #41095

Merged
merged 2 commits into from Mar 22, 2023

Conversation

mandrenguyen
Copy link
Contributor

@mandrenguyen mandrenguyen commented Mar 18, 2023

PR description:

PR validation:

wfs 160.0, 160.02, 160.03, 160.1, 160.2, 160.3 were tested with the option -j0. The cmsDriver commands run successfully, but the cmsRun commands are left for the jenkins tests.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

No backport will be needed.

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41095/34714

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mandrenguyen (Matthew Nguyen) for master.

It involves the following packages:

  • Configuration/AlCa (alca)
  • Configuration/Generator (generators)
  • Configuration/PyReleaseValidation (pdmv, upgrade)

@SiewYan, @mkirsano, @bbilin, @alberto-sanchez, @Saptaparna, @tvami, @cmsbuild, @AdrianoDee, @srimanob, @saumyaphor4252, @kskovpen, @menglu21, @sunilUIET, @francescobrivio, @GurpreetSinghChahal can you please review it and eventually sign? Thanks.
@makortel, @kpedro88, @Martin-Grunewald, @missirol, @tocheng, @mmusich, @fabiocos, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mandrenguyen
Copy link
Contributor Author

@cmsbuild please test workflow 159, 159.01, 159.02, 159.03, 159.1, 159.2, 159.3, 310, 160, 160.02, 160.03, 160.1, 160.2, 160.3

@tvami
Copy link
Contributor

tvami commented Mar 18, 2023

312.0_Pyquen_ZeemumuJets_pt10_2760GeV_2022 is giving this error

----- Begin Fatal Exception 18-Mar-2023 11:15:11 CET-----------------------
An exception of category 'NoSecondaryFiles' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ac722/31393/summary.html
COMMIT: a5577b0
CMSSW: CMSSW_13_1_X_2023-03-17-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41095/31393/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

----- Begin Fatal Exception 18-Mar-2023 11:15:11 CET-----------------------
An exception of category 'NoSecondaryFiles' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------
----- Begin Fatal Exception 18-Mar-2023 11:59:49 CET-----------------------
An exception of category 'NoSecondaryFiles' occurred while
   [0] Constructing the EventProcessor
   [1] Constructing module: class=MixingModule label='mix'
Exception Message:
RootEmbeddedFileSequence no input files specified for secondary input source.
----- End Fatal Exception -------------------------------------------------

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-41095/34719

@menglu21
Copy link
Contributor

sorry, seems the status will not go back to "approved", so i need to start the test again, right?

@mandrenguyen
Copy link
Contributor Author

Yes, I think the test has to be restarted for posterity, but you can already inspect the comparisons produced by the previous test.

@menglu21
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-3ac722/31430/summary.html
COMMIT: 48b21f2
CMSSW: CMSSW_13_1_X_2023-03-19-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41095/31430/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 11 lines from the logs
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3452339
  • DQMHistoTests: Total failures: 10
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3452307
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 209 log files, 160 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@menglu21
Copy link
Contributor

+1

@sunilUIET
Copy link
Contributor

+pdmv

@perrotta
Copy link
Contributor

@cms-sw/upgrade-l2 it is not clear to me why your signature is requested here... In any case, I think it could be useful to have these modified HI workflow available for testing in the 13_1_0_pre2 RelVals. Since we plan to cut that pre-release today, we would like to include this PR in it, if you don't have anything against it.

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@perrotta
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3e995be into cms-sw:master Mar 22, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants