Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed unused variable to avoid valgrind error in SoftElectronMVAEstimator #4129

Merged

Conversation

Dr15Jones
Copy link
Contributor

A member variable which was not being used was being compared against and
valgrind was flagging it as an error. It was trivial to comment out the
variable.

…imator

A member variable which was not being used was being compared against and
valgrind was flagging it as an error. It was trivial to comment out the
variable.
@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2014

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_2_X.

Removed unused variable to avoid valgrind error in SoftElectronMVAEstimator

It involves the following packages:

RecoEgamma/ElectronIdentification

@nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@lgray
Copy link
Contributor

lgray commented Jun 5, 2014

@Dr15Jones @slava77 @StoyanStoynev Obvious no-op change to EGM code, fine with me to bypass standard validation.

@StoyanStoynev
Copy link
Contributor

@Dr15Jones what happened to this PR, I don't see the HEAD reference to it anymore (deleted?):
[~src]> git ls-remote official-cmssw | grep "pull/4129"
c39e51a refs/pull/4129/merge
[~src]>

@Dr15Jones
Copy link
Contributor Author

@nclopezo @ktf no test was run. Is this another case where there was a problem with github not properly handling this pull request so it can't be automatically merged?

@ktf
Copy link
Contributor

ktf commented Jun 9, 2014

There is indeed some issue with this PR. I've contacted github about it. I'll let you know once solved. If urgent I'd suggest to create a new one from scratch.

@slava77
Copy link
Contributor

slava77 commented Jun 10, 2014

it's not the first time we had something similar, no proper ref in cms-sw.
is it the same problem?

@Dr15Jones
Copy link
Contributor Author

My best guess is this is a race condtion in github. The problem appears to happen if I do a git push from my shell and then quickly tell github to make a pull request (say within 1-3 minutes).

@slava77
Copy link
Contributor

slava77 commented Jun 11, 2014

+1

#4129 cff7577
compiles

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Jun 12, 2014
…imator

Removed unused variable to avoid valgrind error in SoftElectronMVAEstimator
@ktf ktf merged commit bd92b77 into cms-sw:CMSSW_7_2_X Jun 12, 2014
@Dr15Jones Dr15Jones deleted the valgrindFixSoftElectronMVAEstimator branch June 12, 2014 16:26
@ktf
Copy link
Contributor

ktf commented Jun 24, 2014

Ok, github people replied and finally acknowledged the issue is on their side. They are investigating. It does indeed look like a race condition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants