New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed unused variable to avoid valgrind error in SoftElectronMVAEstimator #4129
Removed unused variable to avoid valgrind error in SoftElectronMVAEstimator #4129
Conversation
…imator A member variable which was not being used was being compared against and valgrind was flagging it as an error. It was trivial to comment out the variable.
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_2_X. Removed unused variable to avoid valgrind error in SoftElectronMVAEstimator It involves the following packages: RecoEgamma/ElectronIdentification @nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks. |
@Dr15Jones @slava77 @StoyanStoynev Obvious no-op change to EGM code, fine with me to bypass standard validation. |
@Dr15Jones what happened to this PR, I don't see the HEAD reference to it anymore (deleted?): |
There is indeed some issue with this PR. I've contacted github about it. I'll let you know once solved. If urgent I'd suggest to create a new one from scratch. |
it's not the first time we had something similar, no proper ref in cms-sw. |
My best guess is this is a race condtion in github. The problem appears to happen if I do a |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). |
…imator Removed unused variable to avoid valgrind error in SoftElectronMVAEstimator
Ok, github people replied and finally acknowledged the issue is on their side. They are investigating. It does indeed look like a race condition. |
A member variable which was not being used was being compared against and
valgrind was flagging it as an error. It was trivial to comment out the
variable.