Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T rugg ribbon #4163

Merged
merged 1 commit into from
Jun 10, 2014
Merged

T rugg ribbon #4163

merged 1 commit into from
Jun 10, 2014

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Jun 9, 2014

Rename tibtidcommonmaterial:T_Rugg_Ribbon by tibtidcommonmaterial:TIBTID_T_RuggRibbon to avoid annoying warning in each simulation run. Should not affect any result.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2014

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_7_1_X.

T rugg ribbon

It involves the following packages:

Geometry/TrackerCommonData

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor

ianna commented Jun 9, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 9, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Jun 10, 2014
@davidlange6 davidlange6 merged commit d4dac2e into cms-sw:CMSSW_7_1_X Jun 10, 2014
ktf added a commit to ktf/cmssw that referenced this pull request Jun 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants