Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid thread locals #4198

Merged
merged 1 commit into from Jun 11, 2014
Merged

Avoid thread locals #4198

merged 1 commit into from Jun 11, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Jun 10, 2014

There are bugs in the handling of thread locals. This pull request replaces two thread local maps with non-thread local TBB concurrent unordered maps.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_1_X.

Avoid thread locals

It involves the following packages:

FWCore/Utilities

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@Dr15Jones
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@ktf
Copy link
Contributor

ktf commented Jun 11, 2014

This was agreed in yesterday CoreSW meeting. Bypassing ORP approval. @davidlange6 .

ktf added a commit that referenced this pull request Jun 11, 2014
@ktf ktf merged commit ebc64aa into cms-sw:CMSSW_7_1_X Jun 11, 2014
@cmsbuild
Copy link
Contributor

@wmtan wmtan deleted the AvoidThreadLocals branch June 12, 2014 13:45
ktf added a commit to ktf/cmssw that referenced this pull request Jun 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants