Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the magnetic field record for the PixelCPEGeneric configurable #4216

Merged
merged 2 commits into from Jun 15, 2014

Conversation

ahinzmann
Copy link
Contributor

Make the magnetic field record for the PixelCPEGeneric configurable.
No change in the default. So No change in reconstruction.
(Potentially used in HLT for performance improvement)

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ahinzmann for CMSSW_7_1_X.

Pixelcpemagnet

It involves the following packages:

RecoLocalTracker/SiPixelRecHits

@nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @rovere, @gpetruc, @cerati, @threus, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@davidlange6
Copy link
Contributor

please use an input tag instead of a string for this.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jun 12, 2014

@davidlange6 David, did you mean ESInputTag?

@ahinzmann
Copy link
Contributor Author

Thank you for pointing this out. I switched from std:string to ESInputTag.

@cmsbuild
Copy link
Contributor

Pull request #4216 was updated. @nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please check and sign again.

@slava77
Copy link
Contributor

slava77 commented Jun 13, 2014

@ahinzmann please update the subject of the PR so that it is more readable for self-documentation
Change "Pixelcpemagnet" to "Make the magnetic field record for the PixelCPEGeneric configurable." or something like that

@cmsbuild
Copy link
Contributor

@ahinzmann ahinzmann changed the title Pixelcpemagnet Make the magnetic field record for the PixelCPEGeneric configurable Jun 13, 2014
@slava77
Copy link
Contributor

slava77 commented Jun 13, 2014

+1

for #4216 e24e724
everything is OK: no diffs, timing is the same within normal jitter

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Jun 15, 2014
Make the magnetic field record for the PixelCPEGeneric configurable
@davidlange6 davidlange6 merged commit 36bfd12 into cms-sw:CMSSW_7_1_X Jun 15, 2014
@ahinzmann
Copy link
Contributor Author

Is this change automatically propagated to 7_2_X, or should I create another pull request for that?

@ktf ktf mentioned this pull request Jun 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants