Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use std::shared_ptr, not boost::shared_ptr #4227

Merged
merged 1 commit into from Jun 13, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Jun 12, 2014

ROOT6 cannot handle boost::shared_ptr due to the assembler code used in boost. Use std::shared_ptr instead. Use also with ROOT5 for commonality.
Most instances in the framework were modified, except for those in the event setup system, none of which are exposed to ROOT. The changes outside the framework are the necessary adaptation to the framework changes.
Also, std::make_shared<> is used wherever possible, to reduce memory allocations.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_2_X.

Use std::shared_ptr, not boost::shared_ptr

It involves the following packages:

DQM/SiStripMonitorHardware
DQMServices/FwkIO
DQMServices/StreamerIO
DataFormats/Common
DataFormats/FWLite
DataFormats/Provenance
DataFormats/TestObjects
EventFilter/Utilities
FWCore/Common
FWCore/Framework
FWCore/Integration
FWCore/MessageLogger
FWCore/MessageService
FWCore/Modules
FWCore/ParameterSet
FWCore/PluginManager
FWCore/PythonParameterSet
FWCore/ServiceRegistry
FWCore/Services
FWCore/Skeletons
FWCore/Sources
FWCore/TFWLiteSelector
FWCore/Utilities
Fireworks/Core
GeneratorInterface/SherpaInterface
Geometry/HcalTowerAlgo
IOMC/RandomEngine
IOPool/Common
IOPool/Input
IOPool/Output
IOPool/SecondaryInput
IOPool/Streamer
IOPool/TFileAdaptor
Mixing/Base
PhysicsTools/PatExamples
RecoLocalTracker/SiStripClusterizer
SimCalorimetry/EcalSimAlgos
SimCalorimetry/HcalSimAlgos
SimDataFormats/CrossingFrame
SimGeneral/DataMixingModule
SimGeneral/MixingModule

@ianna, @bendavid, @civanch, @ojeda, @cmsbuild, @ktf, @vciulli, @Dr15Jones, @mdhildreth, @rovere, @deguio, @slava77, @mommsen, @vadler, @Degano, @nclopezo, @danduggan, @emeschi, @thuer, @monttj, @alja, @StoyanStoynev can you please review it and eventually sign? Thanks.
@ghellwig, @barvic, @GiacomoSguazzoni, @wddgit, @argiro, @alja, @rovere, @gpetruc, @cerati, @threus, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@vciulli
Copy link
Contributor

vciulli commented Jun 12, 2014

+1

@emeschi
Copy link
Contributor

emeschi commented Jun 12, 2014

+1
On 12 Jun 2014, at 23:08, cmsbuild <notifications@github.commailto:notifications@github.com> wrote:

A new Pull Request was created by @wmtanhttps://github.com/wmtan for CMSSW_7_2_X.

Use std::shared_ptr, not boost::shared_ptr

It involves the following packages:

DQM/SiStripMonitorHardware
DQMServices/FwkIO
DQMServices/StreamerIO
DataFormats/Common
DataFormats/FWLite
DataFormats/Provenance
DataFormats/TestObjects
EventFilter/Utilities
FWCore/Common
FWCore/Framework
FWCore/Integration
FWCore/MessageLogger
FWCore/MessageService
FWCore/Modules
FWCore/ParameterSet
FWCore/PluginManager
FWCore/PythonParameterSet
FWCore/ServiceRegistry
FWCore/Services
FWCore/Skeletons
FWCore/Sources
FWCore/TFWLiteSelector
FWCore/Utilities
Fireworks/Core
GeneratorInterface/SherpaInterface
Geometry/HcalTowerAlgo
IOMC/RandomEngine
IOPool/Common
IOPool/Input
IOPool/Output
IOPool/SecondaryInput
IOPool/Streamer
IOPool/TFileAdaptor
Mixing/Base
PhysicsTools/PatExamples
RecoLocalTracker/SiStripClusterizer
SimCalorimetry/EcalSimAlgos
SimCalorimetry/HcalSimAlgos
SimDataFormats/CrossingFrame
SimGeneral/DataMixingModule
SimGeneral/MixingModule

@iannahttps://github.com/ianna, @bendavidhttps://github.com/bendavid, @civanchhttps://github.com/civanch, @ojedahttps://github.com/ojeda, @cmsbuildhttps://github.com/cmsbuild, @ktfhttps://github.com/ktf, @vciullihttps://github.com/vciulli, @Dr15Joneshttps://github.com/Dr15Jones, @mdhildrethhttps://github.com/mdhildreth, @roverehttps://github.com/rovere, @deguiohttps://github.com/deguio, @slava77https://github.com/slava77, @mommsenhttps://github.com/mommsen, @vadler< /a>, https://github.com/vadler @deganohttps://github.com/degano, @nclopezohttps://github.com/nclopezo, @dandugganhttps://github.com/danduggan, @emeschihttps://github.com/emeschi, @thuerhttps://github.com/thuer, @monttjhttps://github.com/monttj, @aljahttps://github.com/alja, @StoyanStoynevhttps://github.com/StoyanStoynev can you please review it and eventually sign? Thanks.
@ghellwighttps://github.com/ghellwig, @barvichttps://github.com/barvic, @GiacomoSguazzonihttps://github.com/GiacomoSguazzoni, @wddgithttps://github.com/wddgit, @argirohttps://github.com/argiro, @aljahttps://github.com/alja, @roverehttps://github.com/rovere, @gpetruchttps://github.com/gpetruc, @ceratihttps://github.com/cerati, @threushttps://github.com/threus, @venturiahttps://github.com/venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.


Reply to this email directly or view it on GitHubhttps://github.com//pull/4227#issuecomment-45948300.

@cmsbuild
Copy link
Contributor

-1

Tested at: 150390f
I ran the usual tests and I found errors in the following unit tests:

---> test testUtilitiesRFIOAdaptor had ERRORS
---> test testUtilitiesStorageFactory had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4227/108/summary.html

@cmsbuild
Copy link
Contributor

@ktf
Copy link
Contributor

ktf commented Jun 13, 2014

Test failure unrelated. This is purely technical, Jenkins comparisons don't show any change, AFAICT, as expected, I'll merge it before it does not anymore. Complain if not ok.

ktf added a commit that referenced this pull request Jun 13, 2014
Use std::shared_ptr, not boost::shared_ptr
@ktf ktf merged commit 2020c02 into cms-sw:CMSSW_7_2_X Jun 13, 2014
@wmtan wmtan deleted the UseStdSharedPtr branch June 16, 2014 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment