New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use std::shared_ptr, not boost::shared_ptr #4227
Conversation
A new Pull Request was created by @wmtan for CMSSW_7_2_X. Use std::shared_ptr, not boost::shared_ptr It involves the following packages: DQM/SiStripMonitorHardware @ianna, @bendavid, @civanch, @ojeda, @cmsbuild, @ktf, @vciulli, @Dr15Jones, @mdhildreth, @rovere, @deguio, @slava77, @mommsen, @vadler, @Degano, @nclopezo, @danduggan, @emeschi, @thuer, @monttj, @alja, @StoyanStoynev can you please review it and eventually sign? Thanks. |
+1 |
+1 A new Pull Request was created by @wmtanhttps://github.com/wmtan for CMSSW_7_2_X. Use std::shared_ptr, not boost::shared_ptr It involves the following packages: DQM/SiStripMonitorHardware @iannahttps://github.com/ianna, @bendavidhttps://github.com/bendavid, @civanchhttps://github.com/civanch, @ojedahttps://github.com/ojeda, @cmsbuildhttps://github.com/cmsbuild, @ktfhttps://github.com/ktf, @vciullihttps://github.com/vciulli, @Dr15Joneshttps://github.com/Dr15Jones, @mdhildrethhttps://github.com/mdhildreth, @roverehttps://github.com/rovere, @deguiohttps://github.com/deguio, @slava77https://github.com/slava77, @mommsenhttps://github.com/mommsen, @vadler< /a>, https://github.com/vadler @deganohttps://github.com/degano, @nclopezohttps://github.com/nclopezo, @dandugganhttps://github.com/danduggan, @emeschihttps://github.com/emeschi, @thuerhttps://github.com/thuer, @monttjhttps://github.com/monttj, @aljahttps://github.com/alja, @StoyanStoynevhttps://github.com/StoyanStoynev can you please review it and eventually sign? Thanks. — |
-1 Tested at: 150390f ---> test testUtilitiesRFIOAdaptor had ERRORS you can see the results of the tests here: |
Test failure unrelated. This is purely technical, Jenkins comparisons don't show any change, AFAICT, as expected, I'll merge it before it does not anymore. Complain if not ok. |
Use std::shared_ptr, not boost::shared_ptr
ROOT6 cannot handle boost::shared_ptr due to the assembler code used in boost. Use std::shared_ptr instead. Use also with ROOT5 for commonality.
Most instances in the framework were modified, except for those in the event setup system, none of which are exposed to ROOT. The changes outside the framework are the necessary adaptation to the framework changes.
Also, std::make_shared<> is used wherever possible, to reduce memory allocations.