Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix to an "OR" logic in tau discrimination #4233

Merged
merged 1 commit into from Jun 15, 2014

Conversation

mbluj
Copy link
Contributor

@mbluj mbluj commented Jun 13, 2014

Fix to an initialization of passesPrediscriminants variable to make OR logic working properly. In current implementation True is always when mode with logical OR is selected.
It is an urgent bug fix required for new HLT paths with taus. The OR logic is not used in default reco sequences.

@jpavel

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mbluj for CMSSW_7_1_X.

Bug fix to an "OR" logic in tau discrimination

It involves the following packages:

RecoTauTag/RecoTau

@nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@jpavel this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mbluj
Copy link
Contributor Author

mbluj commented Jun 13, 2014

Fix to an initialization of passesPrediscriminants variable in TauDiscriminationProducerBase.cc to make OR logic working properly. In current implementation True is always returned when mode with logical OR is selected.
It is an urgent bug fix required for new HLT paths with taus. The OR logic is not used in default reco sequences.

@jpavel

@Martin-Grunewald
Copy link
Contributor

Automatic forwarding to 72X for this PR.

@slava77
Copy link
Contributor

slava77 commented Jun 13, 2014

and another one with a messed up ref, trying to merge 4233

fatal: Couldn't find remote ref refs/pull/4233/head

need to do mbluj:fixOrLogic

@slava77
Copy link
Contributor

slava77 commented Jun 13, 2014

@ktf
Giulio, did you ever get a feedback from github about broken refs ?
#4233 and #4209 have this problem

@ktf
Copy link
Contributor

ktf commented Jun 13, 2014

Yes. They changed some internals and have now a new (official) way of getting PR refs. I need to try it out and change it, but not before next week.

@slava77
Copy link
Contributor

slava77 commented Jun 13, 2014

+1

for #4233 f7e6e37

tested in CMSSW_7_1_X_2014-06-12-0200 (test area sign710a)

everything is OK: no diffs (neither in reco nor in HLT, whatever is monitored in DQM/Validation)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Jun 15, 2014
Bug fix to an "OR" logic in tau discrimination
@davidlange6 davidlange6 merged commit 83101bb into cms-sw:CMSSW_7_1_X Jun 15, 2014
@ktf ktf mentioned this pull request Jun 23, 2014
@mbluj mbluj deleted the fixOrLogic branch December 3, 2014 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants