New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug fix to an "OR" logic in tau discrimination #4233
Conversation
…R logic working properly
A new Pull Request was created by @mbluj for CMSSW_7_1_X. Bug fix to an "OR" logic in tau discrimination It involves the following packages: RecoTauTag/RecoTau @nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks. |
Fix to an initialization of passesPrediscriminants variable in TauDiscriminationProducerBase.cc to make OR logic working properly. In current implementation True is always returned when mode with logical OR is selected. |
Automatic forwarding to 72X for this PR. |
and another one with a messed up ref, trying to merge 4233
need to do mbluj:fixOrLogic |
Yes. They changed some internals and have now a new (official) way of getting PR refs. I need to try it out and change it, but not before next week. |
Bug fix to an "OR" logic in tau discrimination
Fix to an initialization of passesPrediscriminants variable to make OR logic working properly. In current implementation True is always when mode with logical OR is selected.
It is an urgent bug fix required for new HLT paths with taus. The OR logic is not used in default reco sequences.
@jpavel