Virtual function calls of the for Foo::bar() are not linked to their override

[gartung]

functions, but function calls of the form foo.bar() and foo->bar() are.

[cmsbuild]

A new Pull Request was created by @gartung (Patrick Gartung) for CMSSW_7_2_X.

Virtual function calls of the for Foo::bar() are not linked to their override

It involves the following packages:

Utilities/StaticAnalyzers

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wddgit this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[cmsbuild]

-1
Tested at: a236569
I found an error when building:

Copying tmp/slc6_amd64_gcc481/src/RecoBTag/XMLCalibration/src/RecoBTagXMLCalibration/libRecoBTagXMLCalibration.so to productstore area:
Leaving library rule at RecoBTag/XMLCalibration
Entering library rule at src/RecoCaloTools/Navigation/test
Entering library rule at src/RecoCaloTools/Selectors/test
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-06-16-0200/src/GeneratorInterface/RivetInterface/plugins/RivetHarvesting.cc:1:0:
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-06-16-0200/src/GeneratorInterface/RivetInterface/interface/RivetHarvesting.h:8:36: fatal error: Rivet/Tools/RivetYODA.hh: No such file or directory
 #include "Rivet/Tools/RivetYODA.hh"
                                    ^
compilation terminated.
In file included from /build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-06-16-0200/src/GeneratorInterface/RivetInterface/plugins/RivetAnalyzer.cc:1:0:
/build/cmsbuild/jenkins-workarea/workspace/ib-integration-CMSSW_7_1_X-slc6_amd64_gcc481/CMSSW_7_1_X_2014-06-16-0200/src/GeneratorInterface/RivetInterface/interface/RivetAnalyzer.h:13:36: fatal error: Rivet/Tools/RivetYODA.hh: No such file or directory


you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4248/1699/summary.html

[Dr15Jones]

@nclopezo David, this error can not possibly have happened from the pull request. Please rerun the tests.

[nclopezo]

Hi,
I accidentally put it on the 7_1_X tests. I added the tests of this pr in the queue again.

[gartung]

Is there some way to mark packages that will never be run as part of CMSSW?

[cmsbuild]

+1
Tested at: a236569
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4248/132/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4248/132/summary.html

[ktf]

@gartung Well, they still need to be compiled and run tests.