Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HLT run2 updates #4269

Merged
merged 4 commits into from Jun 17, 2014
Merged

HLT run2 updates #4269

merged 4 commits into from Jun 17, 2014

Conversation

perrotta
Copy link
Contributor

(Tau related) updates to the HLT template menu for Run-2

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @perrotta for CMSSW_7_2_X.

HLT run2 updates

It involves the following packages:

HLTrigger/Configuration

@perrotta, @cmsbuild, @nclopezo, @Martin-Grunewald, @fwyzard, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@perrotta
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

@Martin-Grunewald
Copy link
Contributor

Hi Andrea,

Please check your repository:

You are on branch from-CMSSW_7_2_X_2014-06-17-0200
Checking out package HLTrigger/Configuration
From .
 * [new ref]                    -> merge-attempt
fatal: Couldn't find remote ref refs/pull/4269/head
Unexpected end of command stream
Checking out these packages

@perrotta
Copy link
Contributor Author

Hi Martin.

I think the issue is with the git cms-merge-topic command itself: in
CMSSW_7_2_X_2014-06-17-0200 I get the very same error whatever the PR
I try to cms-merge-topic.

The same happens in CMSSW_7_2_X_2014-06-16-1400

On the other hand, I can
git cms-addpkg
without errors whatever package I want in both IB's

Giulio: any hint?

A.

Martin Grunewald notifications@github.com ha scritto:

Hi Andrea,

Please check your repository:

You are on branch from-CMSSW_7_2_X_2014-06-17-0200
Checking out package HLTrigger/Configuration
From .
 * [new ref]                    -> merge-attempt
fatal: Couldn't find remote ref refs/pull/4269/head
Unexpected end of command stream
Checking out these packages

Reply to this email directly or view it on GitHub:
#4269 (comment)


This message was sent using IMP, the Internet Messaging Program.

@cmsbuild
Copy link
Contributor

Pull request #4269 was updated. @perrotta, @cmsbuild, @nclopezo, @Martin-Grunewald, @fwyzard, @Degano can you please check and sign again.

@perrotta
Copy link
Contributor Author

Correction to what I (just) wrote: that error message appeared when I tried to git cms-merge-topic this PR and the other ALREADY MERGED ones (by mistake I took some from the list of the already merged ones). With the un-merged PR's queued for 72X I had no issues.

I rebased this PR into the latest 72X: I don't understand exactly what did happen, but now everything seems to work as it should.

If you try to git cms-merge-topic this PR now you'll get also the other pull requests that had been already merged on top of CMSSW_7_2_X_2014-06-17-0200, but the list of modified files wrt CMSSW_7_2_X is the one wanted.

A.

@perrotta
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

@Martin-Grunewald
Copy link
Contributor

git cms-merge-topic -u 4224

works fine now!

@Martin-Grunewald
Copy link
Contributor

git cms-merge-topic -u 4269
:-)

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Jun 17, 2014
@ktf ktf merged commit 6739b70 into cms-sw:CMSSW_7_2_X Jun 17, 2014
@perrotta perrotta deleted the hltRun2Updates branch June 17, 2014 14:26
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants