Bugfix: assign correct FED IDs if some FEDs are not in the DAQ #4272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @mgalanti for CMSSW_7_1_X. Bugfix: assign correct FED IDs if some FEDs are not in the DAQ It involves the following packages: DQM/DTMonitorModule @ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks. |
|
+1 |
davidlange6
added a commit
that referenced
this pull request
Jun 17, 2014
Bugfix: assign correct FED IDs if some FEDs are not in the DAQ
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug that manifests when some FEDs are out of the DAQ. The data integrity plots of the first n FEDs where filled no matter what werethe actual FEDs being read out. The fix solves this problem by reading the FED ID from the FED itself and not trying to (wrongly) guess it. A cleaner fix would involve not passing anymore the "id" variable to the processFED method (see FIXME): since it involves changing the interface of a public method, I defer this change to the next CMSSW version.