Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused maps and lines removed from RPCDidisValid #4280

Merged

Conversation

mileva
Copy link
Contributor

@mileva mileva commented Jun 16, 2014

Unused lines in Validation/MuonRPCDigis/src/RPCDigiValid.cc and Validation/MuonRPCDigis/interface/RPCDigiValid.h are removed.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mileva for CMSSW_7_1_X.

Unused maps and lines removed from RPCDidisValid

It involves the following packages:

Validation/MuonRPCDigis

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@deguio
Copy link
Contributor

deguio commented Jun 17, 2014

+1
provided it passes the tests

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Jun 17, 2014
Unused maps and lines removed from RPCDidisValid
@davidlange6 davidlange6 merged commit 2ee1666 into cms-sw:CMSSW_7_1_X Jun 17, 2014
@ktf ktf mentioned this pull request Jun 23, 2014
@mileva mileva deleted the from-CMSSW_7_1_X_2014-06-16-1400 branch March 14, 2017 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants