explicitly convert Time_t to RunNumber to avoid compiler warning

[apfeiffer1]

explicitly convert Time_t to RunNumber for run numbers when creating a pair to make the compiler happy.

[cmsbuild]

A new Pull Request was created by @apfeiffer1 (Andreas Pfeiffer) for CMSSW_7_2_X.

explicitly convert Time_t to RunNumber to avoid compiler warning

It involves the following packages:

Alignment/MillePedeAlignmentAlgorithm

@cmsbuild, @Degano, @diguida, @rcastello, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @frmeier this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[cmsbuild]

+1
Tested at: 40a0f2d
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4285/140/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4285/140/summary.html

[diguida]

@apfeiffer1 looks a trivial change, so I am giving +1. Before doing this, can you tell me how the compiler is not happy? Is it issuing a warning or an error? And why I cannot see it in the IB pages?
Thanks

[apfeiffer1]

Hi Salvatore,

@apfeiffer1 https://github.com/apfeiffer1 looks a trivial change, so I am

giving +1. Before doing this, can you tell me how the compiler is not
happy? Is it issuing a warning or an error? And why I cannot see it in the
IB pages?

ah, sorry, yes. I got a private mail from Giulio who reported that from
someone who used the intel compiler:

"""
The "beginValue" and "endValue" are of type "Time_t" which is "unsigned
long long". However, the pair's type "RunNumber" is just "unsigned int".

GCC 4.8.1 does only warn here with -Wconversion, which is not set by
default. The Intel compiler fails with an error. That type truncation is an
error, unless casted (and hence documented) otherwise.
"""

That's why it's not in the IB pages. I (and Giulio) still thought it would
be good to fix. :)

Thanks,
cheers, andreas

[diguida]

+1
@apfeiffer1 thanks

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).