Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the configuration of the FastTimerService used for Offline DQM: same as #4307 #4308

Merged
merged 2 commits into from Jun 20, 2014
Merged

Update the configuration of the FastTimerService used for Offline DQM: same as #4307 #4308

merged 2 commits into from Jun 20, 2014

Conversation

deguio
Copy link
Contributor

@deguio deguio commented Jun 18, 2014

Update the configuration of the FastTimerService used for Offline DQM

  • read the default configuration for the Service and Cliebnt from the _cfi files, instead of defining the modules from scratch
  • add a module to set the event luminosity

fwyzard and others added 2 commits June 18, 2014 20:02
@fwyzard @deguio
Update the configuration of the FastTimerService used for Offline DQM
2956811 
  - read the default configuration for the Service and Cliebnt from the
    _cfi files, instead of defining the modules from scracth
  - add a module to set the event luminosity
@deguio
move the dqmFastTimerServiceLuminosity in the default DQMOffline sequ…
520695f 
…ence
@deguio
Copy link
Contributor Author

deguio commented Jun 18, 2014

@fwyzard

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @deguio for CMSSW_7_2_X.

same as #4307

It involves the following packages:

DQMOffline/Configuration
DQMServices/Components

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
@barvic, @threus, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@deguio deguio changed the title same as #4307 Update the configuration of the FastTimerService used for Offline DQM: same as #4307 Jun 18, 2014
@deguio
Copy link
Contributor Author

deguio commented Jun 19, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

+1
Tested at: 520695f
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4308/156/summary.html

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Jun 20, 2014
@ktf
Merge pull request #4308 from deguio/DQMFastTimerService_72
b3ac2c3 
Update the configuration of the FastTimerService used for Offline DQM: same as #4307
@ktf ktf merged commit b3ac2c3 into cms-sw:CMSSW_7_2_X Jun 20, 2014
@cmsbuild
Copy link
Contributor

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4308/156/summary.html

@deguio deguio mentioned this pull request Jun 22, 2014
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending dqm-approved fully-signed tests-approved
Projects
None yet
Milestone
CMSSW_7_2_0_pre1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@deguio @cmsbuild @ktf @fwyzard