Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove obsolete check, that caused Valgrind warning as well #4315

Merged

Conversation

VinInn
Copy link
Contributor

@VinInn VinInn commented Jun 19, 2014

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_7_2_X.

remove obsolete check, that cause Valgrind warning as well

It involves the following packages:

RecoLocalTracker/SiPixelRecHits

@nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @rovere, @gpetruc, @cerati, @threus, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@VinInn VinInn changed the title remove obsolete check, that cause Valgrind warning as well remove obsolete check, that caused Valgrind warning as well Jun 19, 2014
@VinInn
Copy link
Contributor Author

VinInn commented Jun 20, 2014

ping. no build? comparison?

@ghost
Copy link

ghost commented Jun 20, 2014

The test crashed due to a github glitch, I resubmitted it now.

@VinInn
Copy link
Contributor Author

VinInn commented Jun 23, 2014

re-ping

@ghost
Copy link

ghost commented Jun 23, 2014

Hi, we are experiencing some issues with jenkins job.
I just re-launched the test through another way...

@ghost
Copy link

ghost commented Jun 23, 2014

+1
Although the jenkins job failed once again it performed the tests which are fine and can be found here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-VinInn:SiPixelRecHits-FixforValgrind/169/summary.html

Sorry for the delay.

@slava77
Copy link
Contributor

slava77 commented Jun 24, 2014

+1

for #4315 96a1741
jenkins OK, also
tested in CMSSW_7_2_X_2014-06-23-1400 (test area)
no diffs as expected

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

davidlange6 added a commit that referenced this pull request Jun 25, 2014
remove obsolete check, that caused Valgrind warning as well
@davidlange6 davidlange6 merged commit c177faa into cms-sw:CMSSW_7_2_X Jun 25, 2014
@VinInn VinInn deleted the SiPixelRecHits-FixforValgrind branch July 13, 2016 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants