Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove line breaks. They cause problems #4323

Merged
merged 1 commit into from Jun 20, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Jun 19, 2014

Totally technical and trivial. Please bypass signatures if not signed promptly, and please merge as soon as convenient.
Line breaks in this classes_def.xml file now cause fatal problems in ROOT6. The dictionary is generated successfully, but the line breaks remain in the generated dictionary file, which now causes fatal compilation errors when the dictionary is compiled. Arguably, the dictionary generation by ROOT should remove the line breaks that cause problems, but the easiest and quickest way to fix this is to remove the line breaks in the xml file.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtan for CMSSW_7_2_ROOT6_X.

Remove line breaks. They cause problems

It involves the following packages:

DataFormats/EgammaReco

@nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

ktf added a commit that referenced this pull request Jun 20, 2014
Remove line breaks. They cause problems
@ktf ktf merged commit 91ff308 into cms-sw:CMSSW_7_2_ROOT6_X Jun 20, 2014
@wmtan wmtan deleted the RemoveLineBreaks branch June 23, 2014 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants