Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reapply #4231 on to #4313 #4358

Merged
merged 3 commits into from Jun 24, 2014
Merged

Conversation

mark-grimes
Copy link

When testing @bsunanda's pull request #4313 an old error comes back in the 142xx tests. Looking at the diffs it looks as though that pull request reverts the fix he put in from #4231.
All I've done is merged #4313 into the latest IB, then

git cherry-pick d493d44

which is the SHA for the only commit in #4231.
@bsunanda could you check the file changes and see if this is actually what you want? If so then close #4313. Thanks.
I've tested that it fixes the 14200 test, I'm currently running other tests and will comment on the pr later.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

Reapply #4231 on to #4313

It involves the following packages:

Geometry/HGCalCommonData
Validation/CheckOverlap

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link
Author

merge

Tested with 4 muons and pions. Had a few failures with the "fatal root error" but passed on retest. Only the known failures in HGCal harvesting. Skipping Geometry signature since both constituent pull requests of this were already signed by Geometry.

cmsbuild added a commit that referenced this pull request Jun 24, 2014
@cmsbuild cmsbuild merged commit 2fae4e7 into cms-sw:CMSSW_6_2_X_SLHC Jun 24, 2014
@mark-grimes mark-grimes deleted the fix4313 branch March 23, 2015 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants