Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Protect against missing PixelClusters #4365

Merged
merged 1 commit into from Jun 26, 2014

Conversation

Martin-Grunewald
Copy link
Contributor

Protect against missing PixelClusters EDProduct;
done is the same way as in the already-existing protection against missing StripClusters.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_7_2_X.

Protect against missing PixelClusters

It involves the following packages:

SimTracker/TrackerHitAssociation

@cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks.
@threus, @GiacomoSguazzoni, @cerati, @rovere, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@Martin-Grunewald
Copy link
Contributor Author

The file-diff is spuriously large as the indentation of the code block encapsulated in
the body of the added if-statement has of course changed...

@ktf
Copy link
Contributor

ktf commented Jun 24, 2014

For a cleaned up version please use:

https://github.com/cms-sw/cmssw/pull/4365/files?w=1

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@Martin-Grunewald
Copy link
Contributor Author

PING PING PING to simulation - please sign!

@civanch
Copy link
Contributor

civanch commented Jun 26, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

davidlange6 added a commit that referenced this pull request Jun 26, 2014
Protect against missing PixelClusters
@davidlange6 davidlange6 merged commit e31bf2f into cms-sw:CMSSW_7_2_X Jun 26, 2014
@Martin-Grunewald Martin-Grunewald deleted the ValidationFix branch June 27, 2014 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants