Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed PrintEventSetupDataRetrieval from a Service to an EDAnalyzer #4385

Merged

Conversation

Dr15Jones
Copy link
Contributor

Changes to the Service API needed for the threaded framework no longer
give Services access to the EventSetup. Therefore to do its job,
PrintEventSetupDataRetrieval needed to be changed to be an EDAnalyzer.

Changes to the Service API needed for the threaded framework no longer
give Services access to the EventSetup. Therefore to do its job,
PrintEventSetupDataRetrieval needed to be changed to be an EDAnalyzer.
@Dr15Jones
Copy link
Contributor Author

@apfeiffer1 here is the change you need

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_2_X.

Changed PrintEventSetupDataRetrieval from a Service to an EDAnalyzer

It involves the following packages:

FWCore/Modules
FWCore/Services

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

@apfeiffer1
Copy link
Contributor

Hi Chris,

@apfeiffer1 https://github.com/apfeiffer1 here is the change you need

Thanks a lot for the fast action !!! :)

   cheers, andreas

@apfeiffer1
Copy link
Contributor

Hi Chris!

Thanks

Salvatore and Roberto


From: apfeiffer1@gmail.com [apfeiffer1@gmail.com] on behalf of Andreas Pfeiffer [andreas.pfeiffer@cern.ch]
Sent: 25 June 2014 09:20
To: cms-sw/cmssw; Giacomo Govi; Salvatore Di Guida; Roberto Castello
Cc: cms-sw/cmssw
Subject: Re: [cmssw] Changed PrintEventSetupDataRetrieval from a Service to an EDAnalyzer (#4385)

Hi Chris,

@apfeiffer1https://github.com/apfeiffer1 here is the change you need

Thanks a lot for the fast action !!! :)

   cheers, andreas

davidlange6 added a commit that referenced this pull request Jun 25, 2014
…nalyzer

Changed PrintEventSetupDataRetrieval from a Service to an EDAnalyzer
@davidlange6 davidlange6 merged commit 054fd27 into cms-sw:CMSSW_7_2_X Jun 25, 2014
@Dr15Jones Dr15Jones deleted the mvPrintEventSetupRetrievalToAnalyzer branch June 25, 2014 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants