Marked debugging static as thread safe in KinematicConstrainedVertexupdatorT #4422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pdatorT A static instance of a class which only has a std::atomic member data was being falsely accused of being thread unsafe by the static analyzer. Given the rare case this represents, it was easier to just mark the static as thread safe using our C++11 attribute.
|
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_2_X. Marked debugging static as thread safe in KinematicConstrainedVertexupdatorT It involves the following packages: RecoVertex/KinematicFit @nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks. |
|
+1 |
ktf
added a commit
that referenced
this pull request
Jun 30, 2014
…xKinematicFit Marked debugging static as thread safe in KinematicConstrainedVertexupdatorT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A static instance of a class which only has a std::atomic member data was being
falsely accused of being thread unsafe by the static analyzer. Given the rare
case this represents, it was easier to just mark the static as thread safe using
our C++11 attribute.