Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Vx3DHLTAnalyzer to thread_unsafe::DQMEDAnalyzer #4429

Merged

Conversation

Dr15Jones
Copy link
Contributor

The Vx3DHLTAnalyzer uses a global std::vector to hold all Vertices
it has seen. Filling this on different threads will lead to crashes
of cmsRun. Therefore changed it to inherit from thread_unsafe::DQMEDAnalyzer.

The Vx3DHLTAnalyzer uses a global std::vector to hold all Vertices
it has seen. Filling this on different threads will lead to crashes
of cmsRun. Therefore changed it to inherit from thread_unsafe::DQMEDAnalyzer.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_2_X.

Set Vx3DHLTAnalyzer to thread_unsafe::DQMEDAnalyzer

It involves the following packages:

DQM/BeamMonitor

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@deguio
Copy link
Contributor

deguio commented Jun 27, 2014

thanks @Dr15Jones for this, but I would prefer to have the code fixed instead of making it a thread_unsafe::DQMEDAnalyzer. that's why I add also @dinardo
cheers,
F.

@Dr15Jones
Copy link
Contributor Author

I would also like the code fixed. However, as it stands the code will crash a threaded job.

@deguio
Copy link
Contributor

deguio commented Jun 27, 2014

+1
approving. I wrote it on my black list.. ;)
ciao,
F.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

davidlange6 added a commit that referenced this pull request Jun 27, 2014
Set Vx3DHLTAnalyzer to thread_unsafe::DQMEDAnalyzer
@davidlange6 davidlange6 merged commit e81a33d into cms-sw:CMSSW_7_2_X Jun 27, 2014
@Dr15Jones Dr15Jones deleted the setVx3DHLTAnalyzerToThreadUnsafe branch June 30, 2014 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants