New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GenericMVAComputerCache bug fix #4452
GenericMVAComputerCache bug fix #4452
Conversation
A new Pull Request was created by @pvmulder (Petra Van Mulders) for CMSSW_7_1_X. GenericMVAComputerCache bug fix It involves the following packages: RecoBTau/JetTagComputer @nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks. |
@@ -19,7 +19,7 @@ class GenericMVAComputerCache { | |||
|
|||
GenericMVAComputer const* getComputer(int index) const; | |||
|
|||
inline bool isEmpty() const; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume the intention was for the function to be inline. Just checking explicitly you don't want it inline anymore.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want it to be inline anymore. I don't know the technical details, @wddgit can tell you more if needed.
No, just checking. |
+1 |
…_bugfix GenericMVAComputerCache bug fix
No description provided.