Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenericMVAComputerCache bug fix #4452

Conversation

pvmulder
Copy link
Contributor

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @pvmulder (Petra Van Mulders) for CMSSW_7_1_X.

GenericMVAComputerCache bug fix

It involves the following packages:

RecoBTau/JetTagComputer

@nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@ferencek this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@@ -19,7 +19,7 @@ class GenericMVAComputerCache {

GenericMVAComputer const* getComputer(int index) const;

inline bool isEmpty() const;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the intention was for the function to be inline. Just checking explicitly you don't want it inline anymore.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want it to be inline anymore. I don't know the technical details, @wddgit can tell you more if needed.

@cmsbuild
Copy link
Contributor

@StoyanStoynev
Copy link
Contributor

No, just checking.

@StoyanStoynev
Copy link
Contributor

+1
Jenkins OK (except wf 25 which is a known technical issue with resimulation).
It is a very trivial change (not inline anymore) in a trivial b-tagging related function, no effect on timing is expected.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Jul 3, 2014
@davidlange6 davidlange6 merged commit 4c759d5 into cms-sw:CMSSW_7_1_X Jul 3, 2014
@ferencek ferencek deleted the 71X_GenericMVAComputerCache_bugfix branch July 3, 2014 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants