Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed HcalRecHitsAnalyzer to thread_unsafe since it uses HcalChannelQuality #4462

Merged
merged 1 commit into from Jul 1, 2014
Merged

Changed HcalRecHitsAnalyzer to thread_unsafe since it uses HcalChannelQuality #4462

merged 1 commit into from Jul 1, 2014

Conversation

Dr15Jones
Copy link
Contributor

Changed HcalRecHitsAnalyzer to inherit from thread_unsafe::DQMEDAnalyzer.
This was needed since the module used HcalChannelQuality with is a thread
unsafe EventSetup product.
This was found by the static analyzer.

@Dr15Jones
Changed HcalRecHitsAnalyzer to thread_unsafe since it uses HcalChanne…
38805c9 
…lQuality

Changed HcalRecHitsAnalyzer to inherit from thread_unsafe::DQMEDAnalyzer.
This was needed since the module used HcalChannelQuality with is a thread
unsafe EventSetup product.
This was found by the static analyzer.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_2_X.

Changed HcalRecHitsAnalyzer to thread_unsafe since it uses HcalChannelQuality

It involves the following packages:

DQMOffline/Hcal

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
@rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@deguio
Copy link
Contributor

deguio commented Jun 30, 2014

+1
thanks Chris

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2014

+1
Tested at: 38805c9
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4462/230/summary.html

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Jul 1, 2014
@ktf
Merge pull request #4462 from Dr15Jones/setHcalRecHitsAnalyzerToThrea…
5467e0b 
…dUnsafe

Changed HcalRecHitsAnalyzer to thread_unsafe since it uses HcalChannelQuality
@ktf ktf merged commit 5467e0b into cms-sw:CMSSW_7_2_X Jul 1, 2014
@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 1, 2014

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4462/230/summary.html

@Dr15Jones Dr15Jones deleted the setHcalRecHitsAnalyzerToThreadUnsafe branch August 27, 2014 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
comparison-pending dqm-approved fully-signed tests-approved
Projects
None yet
Milestone
Next CMSSW_7_2_X
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Dr15Jones @cmsbuild @deguio @ktf