Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace boost:: with std:: where feasible in framework #4546

Merged
merged 1 commit into from Jul 9, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Jul 7, 2014

This pull request replaces most uses of boost classes or functions with the corresponding C++11 std classes or functions in the framework only. This was not done outside the framework. Replaced were boost::bind, boost::cref, boost::ref, boost::function, and boost::mem_fn. A few uses where the change turned out not to be trivial were left alone for now. Most uses of boost;;shared_ptr had already been replaced by std::shared_ptr, but I found a few more uses that were easy to replace.
The only changes outside the framework were the necessary addition of missing includes, almost all of boost/bind.hpp, that were exposed when includes of boost headers were removed from framework headers.
No interfaces used outside the framework are affected by this pull request.
This pull request was tested with the FULL relval matrix, and no errors were introduced by this pull request.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2014

+1

Tested at: d98e082
I ran the usual tests and I found errors in the following unit tests:

---> test testUtilitiesRFIOAdaptor had ERRORS
---> test testUtilitiesStorageFactory had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4546/282/summary.html

However it looks like these are unrelated. Short matrix was ok.

@Dr15Jones
Copy link
Contributor

+1

@wmtan
Copy link
Contributor Author

wmtan commented Jul 7, 2014

Dear "cmsbuild".
The test failures in testUtilities* are preexisting and have nothing to do with this change. Please remove the -1, and, unless there are some new errors, please replace it with +1.
Bill

@Dr15Jones
Copy link
Contributor

The test failures are not related to this pull request.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2014

A new Pull Request was created by @wmtan for CMSSW_7_2_X.

Replace boost:: with std:: where feasible in framework

It involves the following packages:

AnalysisAlgos/SiStripClusterInfoProducer
DQM/SiStripMonitorHardware
DataFormats/Common
DataFormats/FWLite
FWCore/Framework
FWCore/Integration
FWCore/MessageService
FWCore/ParameterSet
FWCore/PluginManager
FWCore/ServiceRegistry
FWCore/Services
FWCore/Utilities
Fireworks/FWInterface
GeneratorInterface/LHEInterface
HLTrigger/Timer
IOPool/Output
IOPool/SecondaryInput
IOPool/Streamer
PhysicsTools/TagAndProbe
RecoBTag/ImpactParameter
RecoTauTag/RecoTau
SimGeneral/MixingModule

@vciulli, @perrotta, @civanch, @bendavid, @danduggan, @fwyzard, @thuer, @monttj, @Martin-Grunewald, @mdhildreth, @deguio, @slava77, @vadler, @ojeda, @rovere, @StoyanStoynev can you please review it and eventually sign? Thanks.
@pvmulder, @jpavel, @wddgit, @alja, @ferencek, @threus, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 7, 2014

@StoyanStoynev
Copy link
Contributor

working on it

@vciulli
Copy link
Contributor

vciulli commented Jul 8, 2014

+1

@StoyanStoynev
Copy link
Contributor

+1
Tested d98e082 on top of CMSSW_7_2_X_2014-07-04-0200. Run extended matrix tests (because of the many files with changes involved). No differences observed (FWLite, DQM based scripts). Jenkins are also fine (except the unit tests mentioned above). I find no issues with the code - changes are consistently introduced throughout the files .

@danduggan
Copy link
Contributor

+1 Minimal change for DQM.

@ktf
Copy link
Contributor

ktf commented Jul 9, 2014

DQM and analysis are trivial. Bypassing.

ktf added a commit that referenced this pull request Jul 9, 2014
Replace boost:: with std:: where feasible in framework
@ktf ktf merged commit 554d20d into cms-sw:CMSSW_7_2_X Jul 9, 2014
@wmtan wmtan deleted the UseCplusplus11InFramework branch July 9, 2014 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants