New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace boost:: with std:: where feasible in framework #4546
Conversation
+1 Tested at: d98e082 ---> test testUtilitiesRFIOAdaptor had ERRORS you can see the results of the tests here: However it looks like these are unrelated. Short matrix was ok. |
+1 |
Dear "cmsbuild". |
The test failures are not related to this pull request. |
A new Pull Request was created by @wmtan for CMSSW_7_2_X. Replace boost:: with std:: where feasible in framework It involves the following packages: AnalysisAlgos/SiStripClusterInfoProducer @vciulli, @perrotta, @civanch, @bendavid, @danduggan, @fwyzard, @thuer, @monttj, @Martin-Grunewald, @mdhildreth, @deguio, @slava77, @vadler, @ojeda, @rovere, @StoyanStoynev can you please review it and eventually sign? Thanks. |
working on it |
+1 |
+1 |
+1 Minimal change for DQM. |
DQM and analysis are trivial. Bypassing. |
Replace boost:: with std:: where feasible in framework
This pull request replaces most uses of boost classes or functions with the corresponding C++11 std classes or functions in the framework only. This was not done outside the framework. Replaced were boost::bind, boost::cref, boost::ref, boost::function, and boost::mem_fn. A few uses where the change turned out not to be trivial were left alone for now. Most uses of boost;;shared_ptr had already been replaced by std::shared_ptr, but I found a few more uses that were easy to replace.
The only changes outside the framework were the necessary addition of missing includes, almost all of boost/bind.hpp, that were exposed when includes of boost headers were removed from framework headers.
No interfaces used outside the framework are affected by this pull request.
This pull request was tested with the FULL relval matrix, and no errors were introduced by this pull request.