Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve offline validation plots #4557

Merged

Conversation

tlampen
Copy link
Contributor

@tlampen tlampen commented Jul 8, 2014

Improvements in offline validation plots: add normalized chi2 and chi2 prob. plots, improve layout of plots etc. Modifications by E. Tomberg.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2014

A new Pull Request was created by @tlampen (Tapio Lampén) for CMSSW_7_2_X.

Improve offline validation plots

It involves the following packages:

Alignment/OfflineValidation

@cmsbuild, @Degano, @diguida, @rcastello, @nclopezo can you please review it and eventually sign? Thanks.
@ghellwig, @mmusich, @frmeier this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@rcastello
Copy link

+1
Provided tests are fine. Anyway mostly cosmetics for alignment validation plots..

@cmsbuild
Copy link
Contributor

cmsbuild commented Jul 8, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

davidlange6 added a commit that referenced this pull request Jul 9, 2014
@davidlange6 davidlange6 merged commit d36d57f into cms-sw:CMSSW_7_2_X Jul 9, 2014
davidlange6 added a commit that referenced this pull request Jul 24, 2014
Backport of #4557. Improve offline validation for70 x
davidlange6 added a commit that referenced this pull request Jul 24, 2014
Backport of #4557. Improve offline validation for71 x
cmsbuild added a commit that referenced this pull request Oct 28, 2014
Backport of #4557.  Improve offline validation for53 x
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants