Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tofBin to stripDigiSimLink, associate recHit via simHit index #4678

Merged
merged 1 commit into from Jul 18, 2014

Conversation

wmtford
Copy link
Contributor

@wmtford wmtford commented Jul 16, 2014

This PR consolidates previous PRs 4520 and 4661. StripDigiSimLinks are modified to include the tofBin; strip digitizer builds simLinks with this additional information; TrackerHitAssociator uses direct simHit pointers for the strips. The performance blow-up observed with PR 4520 is fixed, and redundancy in the simHit maps is removed.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtford for CMSSW_7_2_X.

Add tofBin to stripDigiSimLink, associate recHit via simHit index

It involves the following packages:

SimDataFormats/TrackerDigiSimLink
SimTracker/SiStripDigitizer
SimTracker/TrackerHitAssociation

@cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @rovere, @VinInn, @cnuttens, @cerati, @threus, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Jul 17, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Jul 18, 2014
Add tofBin to stripDigiSimLink, associate recHit via simHit index
@ktf ktf merged commit 05547dc into cms-sw:CMSSW_7_2_X Jul 18, 2014
@wmtford wmtford deleted the newStripSimLink72X branch July 21, 2014 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants