Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New pixel sim link #4711

Merged
merged 11 commits into from Jul 23, 2014
Merged

New pixel sim link #4711

merged 11 commits into from Jul 23, 2014

Conversation

wmtford
Copy link
Contributor

@wmtford wmtford commented Jul 20, 2014

This PR does for the pixels what PR 4678 does for the strips: enables (and uses in the hitAssociator) direct access to the simHits via the PixelDigiSimLinks. (See my presentation at the July 11 Simulation meeting, https://indico.cern.ch/event/329213/.) The change for the pixels is a little deeper than for the strips, since until now the pixel simLinks never supported simHit pointers, CFposition(). The size of a simlink thus grows from 16 to 20 byates.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @wmtford for CMSSW_7_2_X.

New pixel sim link

It involves the following packages:

SimDataFormats/TrackerDigiSimLink
SimTracker/Common
SimTracker/SiPixelDigitizer
SimTracker/TrackerHitAssociation

@cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @rovere, @VinInn, @dkotlins, @cerati, @threus, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Jul 21, 2014

@wmtford, I believe that in TrackerHitAssociator.cc line 143
for (size_t i=0; i<simtrackid.size(); ++i)
should be commented. It is likely has no effect on results.

@wmtford
Copy link
Contributor Author

wmtford commented Jul 21, 2014

@civanch Yes, fixed with my last one-line commit. Thanks.

@cmsbuild
Copy link
Contributor

Pull request #4711 was updated. @cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

Pull request #4711 was updated. @civanch, @mdhildreth can you please check and sign again.

@cmsbuild
Copy link
Contributor

@civanch
Copy link
Contributor

civanch commented Jul 23, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Jul 23, 2014
@ktf ktf merged commit 916d453 into cms-sw:CMSSW_7_2_X Jul 23, 2014
@wmtford wmtford deleted the newPixelSimLink branch July 29, 2014 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants