New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New pixel sim link #4711
New pixel sim link #4711
Conversation
A new Pull Request was created by @wmtford for CMSSW_7_2_X. New pixel sim link It involves the following packages: SimDataFormats/TrackerDigiSimLink @cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks. |
@wmtford, I believe that in TrackerHitAssociator.cc line 143 |
@civanch Yes, fixed with my last one-line commit. Thanks. |
Pull request #4711 was updated. @civanch, @mdhildreth can you please check and sign again. |
+1 |
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). |
This PR does for the pixels what PR 4678 does for the strips: enables (and uses in the hitAssociator) direct access to the simHits via the PixelDigiSimLinks. (See my presentation at the July 11 Simulation meeting, https://indico.cern.ch/event/329213/.) The change for the pixels is a little deeper than for the strips, since until now the pixel simLinks never supported simHit pointers, CFposition(). The size of a simlink thus grows from 16 to 20 byates.