Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4716 with merge conflicts resolved and Phase2 digitiser updated #4738

Merged
merged 4 commits into from Jul 22, 2014

Conversation

mark-grimes
Copy link

#4716 had some small clashes with #4714, fixed those and also copied over the changes to the Phase2 digitiser. @wmtford could you look over my changes to SiPhase2Digitizer and SiPhase2DigitizerAlgorithm to make sure I've done it properly? I pretty much just copied the changes you applied to SiPixelDigitizer and SiPixelDigitizer algorithm.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @mark-grimes (Mark Grimes) for CMSSW_6_2_X_SLHC.

#4716 with merge conflicts resolved and Phase2 digitiser updated

It involves the following packages:

SimDataFormats/TrackerDigiSimLink
SimTracker/Common
SimTracker/SiPhase2Digitizer
SimTracker/SiPixelDigitizer
SimTracker/TrackerHitAssociation

The following packages do not have a category, yet:

SimTracker/SiPhase2Digitizer

@civanch, @nclopezo, @mdhildreth, @cmsbuild, @Degano, @ktf can you please review it and eventually sign? Thanks.
@GiacomoSguazzoni, @rovere, @VinInn, @dkotlins, @wmtford, @cerati, @threus, @venturia this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@mark-grimes
Copy link
Author

merge

Only tested with muons, all fine.

cmsbuild added a commit that referenced this pull request Jul 22, 2014
#4716 with merge conflicts resolved and Phase2 digitiser updated
@cmsbuild cmsbuild merged commit 7ca1799 into cms-sw:CMSSW_6_2_X_SLHC Jul 22, 2014
@wmtford
Copy link
Contributor

wmtford commented Jul 22, 2014

The updates to SimTracker/SiPhase2Digitizer[Algorithm] look correct to me.

@mark-grimes mark-grimes deleted the resolve4716Conflicts branch March 23, 2015 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants