move checkBinLabel as a static function in MonitorElement and use it fro...

[deguio]

...m DQMStore and DQMRootSource

[deguio]

will submit for 72X also.
this fixes the crashing when running MR harvesting (collate histograms across runs)

[cmsbuild]

A new Pull Request was created by @deguio for CMSSW_7_1_X.

move checkBinLabel as a static function in MonitorElement and use it fro...

It involves the following packages:

DQMServices/Core
DQMServices/FwkIO

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

+1
Tested at: 26de863
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4770/1843/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4770/1843/summary.html

[deguio]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

[deguio]

-1
will reimplement this check in a cleaner way (as a method of MonitorElement)

[deguio]

+1
reopening this one. better to leave it like this. more flexible and usable also in the DQMRootSource where the checks are performed starting from TH1 and not ME.