move checkBinLabel as a static function in MonitorElement and use it fro...

[deguio]

...m DQMStore and DQMRootSource
same as: #4770

[cmsbuild]

A new Pull Request was created by @deguio for CMSSW_7_2_X.

move checkBinLabel as a static function in MonitorElement and use it fro...

It involves the following packages:

DQMServices/Core
DQMServices/FwkIO

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[cmsbuild]

-1
Tested at: 3ff2524
When I ran the RelVals I found an error in the following worklfows:
101.0 step1

runTheMatrix-results/101.0_SingleElectronE120EHCAL+SingleElectronE120EHCAL/step1_SingleElectronE120EHCAL+SingleElectronE120EHCAL.log

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4771/457/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4771/457/summary.html

[deguio]

-1
will reimplement this check in a cleaner way (as a method of MonitorElement)
[the crash was anyway not related]

[deguio]

+1
reopening this one. better to leave it like this. more flexible and usable also in the DQMRootSource where the checks are performed starting from TH1 and not ME

[deguio]

please consider merging this one. crash not related.
ciao and thanks,
F.

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (but tests are reportedly failing).

[cmsbuild]

+1
Tested at: 3ff2524
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4771/491/summary.html

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4771/491/summary.html