Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

B2G CSA14 code integration : 72x #4785

Merged
merged 25 commits into from Aug 1, 2014

Conversation

rappoccio
Copy link
Contributor

Same as PR #4784, but now integrating into 72x for forward compatibility.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @rappoccio for CMSSW_7_2_X.

B2G CSA14 code integration : 72x

It involves the following packages:

DataFormats/PatCandidates
PhysicsTools/PatAlgos
RecoJets/Configuration
RecoJets/JetProducers
TopQuarkAnalysis/TopPairBSM

@nclopezo, @monttj, @cmsbuild, @StoyanStoynev, @slava77, @vadler, @Degano can you please review it and eventually sign? Thanks.
@yslai, @TaiSakuma, @nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

-1

Tested at: 4056da1
I ran the usual tests and I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4785/473/summary.html

@cmsbuild
Copy link
Contributor

-1

Tested at: 4056da1
I ran the usual tests and I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4785/477/summary.html

@cmsbuild
Copy link
Contributor

Pull request #4785 was updated. @nclopezo, @monttj, @cmsbuild, @StoyanStoynev, @slava77, @vadler, @Degano can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jul 30, 2014

+1

for #4785 2f2cd10
based on jenkins (compiles/runs)
the modified/new modules in reco files are not used in standard sequences

@monttj
Copy link
Contributor

monttj commented Jul 30, 2014

+1
This should not affect the PAT sequence.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

davidlange6 added a commit that referenced this pull request Aug 1, 2014
@davidlange6 davidlange6 merged commit 0395ed6 into cms-sw:CMSSW_7_2_X Aug 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants