Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FastJet HLT cfi file in 72X #4799

Merged
merged 3 commits into from Aug 1, 2014

Conversation

Martin-Grunewald
Copy link
Contributor

Fix FastJet HLT cfi file - fix of PR #4705 .

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Martin-Grunewald (Martin Grunewald) for CMSSW_7_2_X.

Fix FastJet HLT cfi file in 72X

It involves the following packages:

RecoJets/JetProducers

@nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@yslai, @TaiSakuma, @nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

Pull request #4799 was updated. @nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please check and sign again.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@slava77
Copy link
Contributor

slava77 commented Jul 30, 2014

+1

#4799 cbe4387

compiles (the file is not used anywhere yet)

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

@slava77
Copy link
Contributor

slava77 commented Jul 30, 2014

@nclopezo @Degano
Please investigate why comparisons in this PR show differences, especially the ones in data (e.g. 4.53 or 1000.0)
There are no changes here to trigger discrepancies.
It's been happening fairly frequently recently.

Thanks

davidlange6 added a commit that referenced this pull request Aug 1, 2014
@davidlange6 davidlange6 merged commit 4201a10 into cms-sw:CMSSW_7_2_X Aug 1, 2014
@Martin-Grunewald Martin-Grunewald deleted the FixFastJetHLT72X branch August 7, 2014 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants