Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HLT process name in Top PAG validation code #4816

Merged

Conversation

ebouvier
Copy link

The InputTag used to be hardcoded which is not convenient for testing development menus.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ebouvier for CMSSW_7_2_X.

Fix HLT process name in Top PAG validation code

It involves the following packages:

HLTriggerOffline/Top

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Jul 29, 2014

@ebouvier
don't you have to add something in the corresponding cfi files? i.e. moving the HLT string from c++ to config?

@ebouvier
Copy link
Author

Hi Federico @deguio,
I've run it and the result was totally meaningful.
Actually the idea is that if we re-run the HLT sequence (so with a new name) we want it to be automatically the picked one by the validation code, without changing nor the cfi files, nor the .h ones.
Cheers.

@deguio
Copy link
Contributor

deguio commented Jul 31, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

@ebouvier
Copy link
Author

Thank you @deguio !

davidlange6 added a commit that referenced this pull request Aug 1, 2014
Fix HLT process name in Top PAG validation code
@davidlange6 davidlange6 merged commit eb308a9 into cms-sw:CMSSW_7_2_X Aug 1, 2014
@ebouvier ebouvier deleted the FixHLTProcessNameTopValidation branch September 10, 2014 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants