Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix setDet for Projected Hit #4901

Merged
merged 1 commit into from Aug 8, 2014
Merged

Fix setDet for Projected Hit #4901

merged 1 commit into from Aug 8, 2014

Conversation

VinInn
Copy link
Contributor

@VinInn VinInn commented Aug 7, 2014

trivial fix
discovered by @mtosi
occurs when refitting tracks issued by HLT.
No standard workflow ever exercise it.

I would like to ask a fast-track for the approval of this PR to allow @mtosi to proceed with her work
w/o being forced to recompile the whole CMSSW.

The fix is trivial. It involves recompiling the whole CMSSW. It cannot affect any usual workflow.
Therefore if compiles and pass tests, should be good enough

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2014

A new Pull Request was created by @VinInn (Vincenzo Innocente) for CMSSW_7_2_X.

fix setDet for Projected Hit

It involves the following packages:

DataFormats/TrackerRecHit2D
DataFormats/TrackingRecHit

@nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@slava77
Copy link
Contributor

slava77 commented Aug 7, 2014

jenkins compile and test should be enough

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2014

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2014

@slava77
Copy link
Contributor

slava77 commented Aug 7, 2014

+1

for #4901 26d3cf5
jenkins tests run ok

@cmsbuild
Copy link
Contributor

cmsbuild commented Aug 7, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Aug 8, 2014
Fix setDet for Projected Hit.
@ktf ktf merged commit 59beca4 into cms-sw:CMSSW_7_2_X Aug 8, 2014
@ktf ktf changed the title fix setDet for Projected Hit Fix setDet for Projected Hit Aug 8, 2014
@VinInn VinInn deleted the fixProj branch July 13, 2016 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants