RPCMuon bugfix in MuonIdProducer

[jhgoh]

The RPCMuon is mis-implemented as a subset of TrackerMuons.
Originally it is designed to be a complementary ones to the TM's.

[cmsbuild]

A new Pull Request was created by @jhgoh (Junghwan John Goh) for CMSSW_7_2_X.

RPCMuon bugfix in MuonIdProducer

It involves the following packages:

RecoMuon/MuonIdentification

@nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please review it and eventually sign? Thanks.
@bellan, @bachtis, @rociovilar this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

[StoyanStoynev]

@jhgoh could you clarify your description? With the new code you are adding to the muon collection muons that are RPC only (and eventually reducing the calo muons). In the previous code they would not be there at all, thus they were not a "subset" of the tracker muons, if anything they were a subset of the calo muons. Am I reading it wrong?
What about type setting? What is the purpose of the line 590 (trackerMuon.setType( reco::Muon::TrackerMuon | reco::Muon::RPCMuon );), shouldn't you do that now separately for TrMu and RPCMu after line 623? As it stands now, how do we know if the muon in the collection is TrMu or RPCMu
(given it is not GLB/STA)?

[StoyanStoynev]

Ignore my comment about calo muons it is wrong and not relevant, the rest is relevant.

[jhgoh]

The original purpose of RPCMuon is to keep muons even if DT/CSC hits are missing.
The current code will skip muons if it does not pass 'goodTrackerMuon' condition even though it passes 'goodRPCMuon'. Thus some muons only with RPC hit will be lost (although it is expected not to be often in ideal situations).

For the typesetting: I missed this part, I think this typesetting have to be moved to line 623, with separate if-statements.

[cmsbuild]

+1
Tested at: d69968a
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4902/572/summary.html

[StoyanStoynev]

Then I expect you to update the PR with the new if-statements.

[jhgoh]

Applied RPCMuon type set.

[cmsbuild]

Pull request #4902 was updated. @nclopezo, @cmsbuild, @Degano, @StoyanStoynev, @slava77 can you please check and sign again.

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4902/622/summary.html

[slava77]

+1

for #4902 4060bf0

tested with extended/higher stat tests in CMSSW_7_2_X_2014-08-11-1400 (test area sign408)

Changes as expected

• RPC flag is now set correctly (previously every tracker muon had RPC flag set)
• additional RPC (notTracker) muons appear mainly in jetty events (~10% in QCD dijet; vs single-muon events with <0.1% added)

[ktf]

Bypassing DQM since the change is the same also for RECO and Slava was ok with it. @deguio @danduggan complain if not ok.